Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add COI integration to islandora settings form. #986

Merged
merged 5 commits into from
Nov 17, 2023

Conversation

rosiel
Copy link
Member

@rosiel rosiel commented Oct 23, 2023

GitHub Issue: Islandora-Devops/islandora-starter-site#112

What does this Pull Request do?

Adds a key to the islandora settings form that allows the Config Override Inspector (COI) module to note these fields as overridden. (It can disable the fields and display a custom message too)

What's new?

Enables COI on select islandora settings fields.

  • Does this change add any new dependencies? No - this does not do anything if COI is not enabled)
  • Does this change require any other modifications to be made to the repository
    (i.e. Regeneration activity, etc.)? No
  • Could this change impact execution of existing code? No

How should this be tested?

  • Install Islandora using a method that uses the settings.php file to override config - for example, the site template currently does this.
  • Visit the form fields for overridden values. You will see the "saved config" value which is overridden so not actually active. You will also be able to change the "saved config" value.
  • Install Config Override Inspector (coi). Before this PR, nothing happens. But with this PR, the Islandora settings values are marked as overridden.
Screenshot 2023-10-23 at 1 55 31 PM ("Provide User identification" section opened for clarity; the form has it closed by default).

Documentation Status

  • Does this change existing behaviour that's currently documented? no
  • Does this change require new pages or sections of documentation? perhaps
  • Who does this need to be documented for? site admins
  • Associated documentation pull request(s): ___ or documentation issue ___

Additional Notes:

Any additional information that you think would be helpful when reviewing this
PR.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/committers

@ysuarez ysuarez requested a review from aOelschlager November 8, 2023 18:09
Copy link

@aOelschlager aOelschlager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These show up just like the screenshot in the pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants