Use FileUrlGeneratorInterface

[seth-shaw-asu]

GitHub Issue: N/A

Ran into an issue where I couldn't update an entity_view_display:

TypeError: Drupal\islandora\Plugin\Field\FieldFormatter\IslandoraImageFormatter::__construct(): Argument #11 ($file_url_generator) must be of type Drupal\Core\File\FileUrlGenerator, Drupal\cdn\File\FileUrlGenerator given, called in /var/www/html/drupal/web/modules/contrib/islandora/src/Plugin/Field/FieldFormatter/IslandoraImageFormatter.php on line 106 in /var/www/html/drupal/web/modules/contrib/islandora/src/Plugin/Field/FieldFormatter/IslandoraImageFormatter.php on line 63
#0 /var/www/html/drupal/web/modules/contrib/islandora/src/Plugin/Field/FieldFormatter/IslandoraImageFormatter.php(106): Drupal\islandora\Plugin\Field\FieldFormatter\IslandoraImageFormatter->__construct()
#1 /var/www/html/drupal/web/core/lib/Drupal/Core/Field/FormatterPluginManager.php(64): Drupal\islandora\Plugin\Field\FieldFormatter\IslandoraImageFormatter::create()
...

What does this Pull Request do?

Replaces FileUrlGenerator class with FileUrlGeneratorInterface which preserves compatibility with CDN replacements.

How should this be tested?

Not sure how to test this quickly. Mine was probably triggered by either our S3 integration or Cloudflare. Not sure which.

But, really, just smoke-test it and make sure tests pass.

Interested parties

@Islandora/committers

[seth-shaw-asu]

As per https://www.drupal.org/project/drupal/issues/3403491, the test failures caught an unfortunate window where 10.2.x broke the API, but should be okay if I just retry them. 🤞

[whikloj]

👍

[whikloj]

💯 👍 🤦