Change to Boolean logic

[ajstanley]

GitHub Issue: (Issue 998)

• Other Relevant Links (Google Groups discussion, related pull requests,
  Release pull requests, etc.)

What does this Pull Request do?

There's a small error in operator precedence allowing us to get to a place in the code where we shouldn't be

What's new?

A minor change in logic

How should this be tested?

You can test this with a non-tiff image missing dimensional data, but it's unlikely you'd have one on hand.
This should illustrate the change.

 <?PHP
# Before the change
$mime = 'image/jp2';
$height = NULL;
$width = NULL;
if ($mime === 'image/tif' && !$height || !$width){
	print "This line should not be visible";
}

 <?PHP
# After the change
$mime = 'image/jp2';
$height = NULL;
$width = NULL;
if ($mime === 'image/tif' && (!$height || !$width)){
	print "This line should not be visible";
}
 

Documentation Status

• Does this change existing behaviour that's currently documented?
• Does this change require new pages or sections of documentation?
• Who does this need to be documented for?
• Associated documentation pull request(s): ___ or documentation issue ___

Additional Notes:

Any additional information that you think would be helpful when reviewing this
PR.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/committers