Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove asterisks from phpcpd command line. #16

Merged
merged 1 commit into from
Sep 14, 2022

Conversation

alxp
Copy link
Contributor

@alxp alxp commented Sep 14, 2022

What does this Pull Request do?

Somehow even though it ran correctly in my local Linux box with the "--suffix *.php" etc options, it was still failing in CI.

Removed the asterisks and tested on the branch 'GitHub-actions-test-breakout-mirador' of islandora_ci.

  • Related GitHub Issue: (link)

[BUG]phpcpd is being invoked incorrectly

What's new?

The phpcpd invocation now has suffixes with no asterisk before the file extension.

  • Does this change add any new dependencies? No
  • Does this change require any other modifications to be made to the repository
    (i.e. Regeneration activity, etc.)? No
  • Could this change impact execution of existing code? No

How should this be tested?

Cause the CI to run on this PR:

Islandora/islandora_defaults#75

Documentation Status

  • Does this change existing behaviour that's currently documented? No
  • Does this change require new pages or sections of documentation? No
  • Who does this need to be documented for? CI robot
  • Associated documentation pull request(s): ___ or documentation issue ___

Additional Notes:

Any additional information that you think would be helpful when reviewing this

dunse hat
Tested on the CI infrastructure and it works:

image

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/committers

@seth-shaw-asu seth-shaw-asu merged commit 6592b77 into github-actions Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants