Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily exclude PDF if D10 #18

Merged
merged 1 commit into from
Jun 14, 2023
Merged

Conversation

rosiel
Copy link
Member

@rosiel rosiel commented May 25, 2023

What does this Pull Request do?

Drupal 10 tests for all our modules fail because Islandora CI installs PDF, which doesn't have a D10 version yet.

It would be really useful to be able to test the majority of our modules, which do not require pdf, on Drupal 10. Therefore I'm proposing this as a temporary fix.

What's new?

Skip PDF installation if Drupal 10.

How should this be tested?

I'm not sure, but once committed, D10 pull requests should be tested with a suite that doesn't fail when trying to install the pdf module.

Documentation Status

  • Does this change existing behaviour that's currently documented? NO
  • Does this change require new pages or sections of documentation? NO
  • Who does this need to be documented for? NO
  • Associated documentation pull request(s): ___ or documentation issue ___ N/A

Additional Notes:

Any additional information that you think would be helpful when reviewing this
PR.

Interested parties

@adam-vessey @whikloj

@seth-shaw-asu seth-shaw-asu merged commit 859a928 into github-actions Jun 14, 2023
@rosiel rosiel deleted the rosiel-patch-1 branch June 14, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants