-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'Original Name' field to Media #13
Conversation
I can test this, but not until the weekend. |
@Islandora/8-x-committers anyone know why travis stalled? |
Travis says this is not an active repository. This is an issue for @dannylamb, I believe. |
Is it because this has not been deCLAWed yet? |
PR 13 does not exist according to https://travis-ci.com/Islandora/islandora_defaults/pull_requests 🤷♂️ Try poking Travis with a white space commit and see if he responds. Everything's set up and should™️ function fine as-is due to redirects (de-CLAWing would still be preferable tho). |
@dannylamb and @mjordan, since I needed a commit to poke it anyway I just went ahead and declawed travis. Looks like that did the trick. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with Islandora/islandora#735, everything works as intended.
Even though travis says "66.2 | 7.3 | errored | This job is allowed to fail." I can't merge because of the failed build. |
@mjordan, once you merge Islandora/islandora#735 I can restart Travis and it should build fine then. |
@seth-shaw-unlv OK, I just merged Islandora/islandora#735. |
Travis builds are restarted. |
Hm, still failing. |
Hey! Looks like this isn't my fault. Packagist is still pointing composer at Islandora-CLAW/islandora. (See the 'Source' link on the packagist page.) I don't know who needs to make that change, although @dannylamb and @DiegoPino are both listed on the packagist page. Once that is fixed this should work fine. I just need to revert my travis changes. I'll do that after the Packagist references are fixed. |
Cool, ping me when everything is ready and I'll merge. |
@seth-shaw-unlv I hit the update button again on packagist and now the source page leads to Islandora/islandora. I'm restarting the build on Travis to see if gets picked up. |
@dannylamb, now https://packagist.org/packages/islandora/islandora#dev-8.x-1.x has a source value of the 7.x branch (https://github.com/Islandora/islandora/tree/7.x). |
@seth-shaw-unlv Just had to jiggle the cable on it. You're good to go now. |
Tested with Islandora/islandora#735, works as described. |
GitHub Issue: Islandora/documentation#1276
What does this Pull Request do?
Adds an 'Original Name' field to Media.
What's new?
(i.e. Regeneration activity, etc.)? No.
How should this be tested?
Test with Islandora/islandora#735
Interested parties
@mjordan, @Islandora/8-x-committers