Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Original Name' field to Media #13

Merged
merged 6 commits into from
Oct 23, 2019
Merged

Add 'Original Name' field to Media #13

merged 6 commits into from
Oct 23, 2019

Conversation

seth-shaw-unlv
Copy link
Contributor

GitHub Issue: Islandora/documentation#1276

What does this Pull Request do?

Adds an 'Original Name' field to Media.

What's new?

  • Added a pile of configs to add the 'Original Name' field, plus their PREMIS 3 mappings.
  • Does this change require documentation to be updated? No.
  • Does this change add any new dependencies? No.
  • Does this change require any other modifications to be made to the repository
    (i.e. Regeneration activity, etc.)? No.
  • Could this change impact execution of existing code? No.

How should this be tested?

Test with Islandora/islandora#735

Interested parties

@mjordan, @Islandora/8-x-committers

@mjordan
Copy link
Contributor

mjordan commented Oct 17, 2019

I can test this, but not until the weekend.

@mjordan mjordan self-requested a review October 18, 2019 14:18
@mjordan
Copy link
Contributor

mjordan commented Oct 22, 2019

@Islandora/8-x-committers anyone know why travis stalled?

@seth-shaw-unlv
Copy link
Contributor Author

Travis says this is not an active repository. This is an issue for @dannylamb, I believe.

@manez
Copy link
Member

manez commented Oct 22, 2019

Is it because this has not been deCLAWed yet?

@dannylamb
Copy link
Contributor

PR 13 does not exist according to https://travis-ci.com/Islandora/islandora_defaults/pull_requests 🤷‍♂️ Try poking Travis with a white space commit and see if he responds. Everything's set up and should™️ function fine as-is due to redirects (de-CLAWing would still be preferable tho).

@seth-shaw-unlv
Copy link
Contributor Author

@dannylamb and @mjordan, since I needed a commit to poke it anyway I just went ahead and declawed travis. Looks like that did the trick.

Copy link
Contributor

@mjordan mjordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with Islandora/islandora#735, everything works as intended.

@mjordan
Copy link
Contributor

mjordan commented Oct 22, 2019

Even though travis says "66.2 | 7.3 | errored | This job is allowed to fail." I can't merge because of the failed build.

@seth-shaw-unlv
Copy link
Contributor Author

@mjordan, once you merge Islandora/islandora#735 I can restart Travis and it should build fine then.

@mjordan
Copy link
Contributor

mjordan commented Oct 22, 2019

@seth-shaw-unlv OK, I just merged Islandora/islandora#735.

@seth-shaw-unlv
Copy link
Contributor Author

Travis builds are restarted.

@mjordan
Copy link
Contributor

mjordan commented Oct 22, 2019

Hm, still failing.

@seth-shaw-unlv
Copy link
Contributor Author

Hey! Looks like this isn't my fault. Packagist is still pointing composer at Islandora-CLAW/islandora. (See the 'Source' link on the packagist page.) I don't know who needs to make that change, although @dannylamb and @DiegoPino are both listed on the packagist page.

Once that is fixed this should work fine. I just need to revert my travis changes. I'll do that after the Packagist references are fixed.

@mjordan
Copy link
Contributor

mjordan commented Oct 22, 2019

Cool, ping me when everything is ready and I'll merge.

@dannylamb
Copy link
Contributor

@seth-shaw-unlv I hit the update button again on packagist and now the source page leads to Islandora/islandora. I'm restarting the build on Travis to see if gets picked up.

@seth-shaw-unlv
Copy link
Contributor Author

@dannylamb, now https://packagist.org/packages/islandora/islandora#dev-8.x-1.x has a source value of the 7.x branch (https://github.com/Islandora/islandora/tree/7.x).

@dannylamb
Copy link
Contributor

@seth-shaw-unlv Just had to jiggle the cable on it. You're good to go now.

@mjordan mjordan merged commit bb64d5b into Islandora:8.x-1.x Oct 23, 2019
@mjordan
Copy link
Contributor

mjordan commented Oct 23, 2019

Tested with Islandora/islandora#735, works as described.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants