Mirador patch

[elizoller]

GitHub Issue: (Islandora/documentation#1608)

What does this Pull Request do?

Moves the "Mirador" display hint to the islandora_mirador submodule

What's new?

• removes "Mirador" term from the migrate in the main part of islandora_defaults
• adds an install and an update hook to add the term if it doesn't exist

How should this be tested?

• install a regular islandora-playbook
• be sure you have no vestiges of islandora_mirador (including the term in the Islandora Display vocabulary)
• install islandora_mirador submodule
• check that you now have a term "Mirador"

Interested parties

@Islandora/8-x-committers
@mjordan
@kayakr
@seth-shaw-unlv

[mjordan]

Works as intended. The term "Mirador" is created and the Contexts using it are created as well.

[mjordan]

@elizoller Not directly related to this issue, but I notice that https://github.com/Islandora/islandora_defaults/blob/8.x-1.x/modules/islandora_mirador/config/install/context.context.mirador.yml#L18 contains a hard-coded term ID. This should be removed.

In your branch, I just uninstalled the Mirador module and deleted the "Mirador" term and Contexts, then deleted https://github.com/Islandora/islandora_defaults/blob/8.x-1.x/modules/islandora_mirador/config/install/context.context.mirador.yml#L16-L18 and re-enabled the Islandora Mirador module and the context was created as expected.

The paged content Context doesn't specify this term ID.

[elizoller]

Ok, i'll swap that for the URI

[seth-shaw-unlv]

Travis is failing on coding style in the Mirador block.

[seth-shaw-unlv]

Oddly, that block it is failing on isn't part of the PR, but we didn't catch it the first time.

[elizoller]

for whatever reason when i run phpcs on my local, it doesn't catch this error and i'm using the same packages. maybe i'm running a different version of phpcs or something.
regardless - i'll have a new commit up here soon

[mjordan]

Very good, I'll retest and merge if all goes well.

[mjordan]

Retested after updates, all is 👍.