Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change abstract from string to text #58

Merged
merged 1 commit into from
Mar 17, 2022
Merged

change abstract from string to text #58

merged 1 commit into from
Mar 17, 2022

Conversation

seth-shaw-unlv
Copy link
Contributor

GitHub Issue: Islandora/documentation#1977

See the conversation on Slack.

What does this Pull Request do?

Changes the abstract field from string to text to allow formatting, such as italics.

As a bonus, adds abstract to the other node display modes since it was only in default and not in binary, pdfjs, or openseadragon.

What's new?

  • Changes the abstract field from string to text and updates the related form and view displays.
  • Does this change require documentation to be updated? No
  • Does this change add any new dependencies? No
  • Does this change require any other modifications to be made to the repository
    (i.e. Regeneration activity, etc.)? This is for new installs.
  • Could this change impact execution of existing code? No.

How should this be tested?

  • Spin up an islandora_defaults, the abstract field won't allow formatting.
  • Spin up a new islandora_defaults with the PR, the abstract field does support formatting.

Interested parties

@Islandora/8-x-committers, esp @rosiel.

@rosiel rosiel merged commit b00bff1 into Islandora:2.x Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants