Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on Defaults in config/optional. #15

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

rosiel
Copy link
Member

@rosiel rosiel commented Nov 24, 2022

What does this Pull Request do?

Provide a brief description of what the intended result of the PR will be and/or what
problem it solves.

What's new?

Removes dependency of a specific config on islandora defaults.

How should this be tested?

You should be able to install the module and (if you have the starter site) see the mirador view mode for islandora_object? (i'm actually not sure)

Documentation Status

  • Does this change existing behaviour that's currently documented? no
  • Does this change require new pages or sections of documentation? no
  • Who does this need to be documented for? no
  • Associated documentation pull request(s): ___ or documentation issue ___

Additional Notes:

Any additional information that you think would be helpful when reviewing this
PR.

Interested parties

@noahwsmith

@noahwsmith
Copy link

#11 was solved by simply having 2.2.2 https://github.com/Islandora/islandora_mirador/releases/tag/2.2.2 available as a tag. Removing the dependency is extra gravy!

@seth-shaw-asu seth-shaw-asu merged commit e973717 into 2.x Nov 30, 2022
@seth-shaw-asu seth-shaw-asu deleted the remove-defaults branch November 30, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants