Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify site/node-relative manifest endpoint reference. #20

Merged
merged 2 commits into from
May 31, 2023

Conversation

adam-vessey
Copy link
Contributor

Using the provided token should avoid any issues with URL schemes or hostnames or ports and so on.

What does this Pull Request do?

Use the built token instead of manually requiring it to be rebuilt.

  • Related GitHub Issue: (link)

  • Other Relevant Links: (Google Groups discussion, related pull requests,
    Release pull requests, etc.)

What's new?

Uses the [node:url:unaliased:absolute] to build out the base URL to the node. This token is presently provided by the "Token" module (between https://git.drupalcode.org/project/token/-/blob/8.x-1.x/token.tokens.inc#L56, https://git.drupalcode.org/project/token/-/blob/8.x-1.x/token.tokens.inc#L369-373 and https://git.drupalcode.org/project/token/-/blob/8.x-1.x/token.tokens.inc#L361-364), on which this module is already dependent (

)

How should this be tested?

A description of what steps someone could take to:

  • Reproduce the problem you are fixing (if applicable)
  • Test that the Pull Request does what is intended.
  • Please be as detailed as possible.
  • Good testing instructions help get your PR completed faster.

Documentation Status

  • Does this change existing behaviour that's currently documented?
  • Does this change require new pages or sections of documentation?
  • Who does this need to be documented for?
  • Associated documentation pull request(s): ___ or documentation issue ___

Additional Notes:

Any additional information that you think would be helpful when reviewing this
PR.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/committers

Using the provided token should avoid any issues with URL schemes or
hostnames or ports and so on.
@rosiel
Copy link
Member

rosiel commented May 30, 2023

100%. We could change the example text in the form element's description, too?
https://github.com/Islandora/islandora_mirador/blob/2.x/src/Form/MiradorConfigForm.php#L63

@adam-vessey adam-vessey marked this pull request as ready for review May 30, 2023 22:19
@alxp alxp merged commit b390e38 into Islandora:2.x May 31, 2023
@adam-vessey adam-vessey deleted the feature/simplify-default-url branch May 31, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants