Simplify site/node-relative manifest endpoint reference. #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the provided token should avoid any issues with URL schemes or hostnames or ports and so on.
What does this Pull Request do?
Use the built token instead of manually requiring it to be rebuilt.
Related GitHub Issue: (link)
Other Relevant Links: (Google Groups discussion, related pull requests,
Release pull requests, etc.)
What's new?
Uses the
[node:url:unaliased:absolute]
to build out the base URL to the node. This token is presently provided by the "Token" module (between https://git.drupalcode.org/project/token/-/blob/8.x-1.x/token.tokens.inc#L56, https://git.drupalcode.org/project/token/-/blob/8.x-1.x/token.tokens.inc#L369-373 and https://git.drupalcode.org/project/token/-/blob/8.x-1.x/token.tokens.inc#L361-364), on which this module is already dependent (islandora_mirador/islandora_mirador.info.yml
Line 9 in 33843dc
How should this be tested?
A description of what steps someone could take to:
Documentation Status
Additional Notes:
Any additional information that you think would be helpful when reviewing this
PR.
Interested parties
Tag (@ mention) interested parties or, if unsure, @Islandora/committers