Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #27: Drupal 10 compatibility. #28

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Issue #27: Drupal 10 compatibility. #28

merged 1 commit into from
Jul 19, 2023

Conversation

alxp
Copy link
Contributor

@alxp alxp commented Jul 9, 2023

GitHub Issue: #27

What does this Pull Request do?

Drupal 10 compatibility fixes.

What's new?

A in-depth description of the changes made by this PR. Technical details and
possible side effects.

Fix errors reported by Upgrade Status module.

  • Does this change add any new dependencies? No
  • Does this change require any other modifications to be made to the repository
    (i.e. Regeneration activity, etc.)? No
  • Could this change impact execution of existing code? No

How should this be tested?

Enable the module on a Drupal 10 site. Note that as of the creation of this PR, the Islandora d10 compatibility fix PR is still open so you may still need to check that branch out also.

Go to the Islandora Mirador Administration page and ensure settings can be altered and saved.

Check that Mirador functions as it does on an Islandora site running on Drupal 9.

Documentation Status

  • Does this change existing behaviour that's currently documented?
  • Does this change require new pages or sections of documentation?
  • Who does this need to be documented for?
  • Associated documentation pull request(s): ___ or documentation issue ___

Additional Notes:

Any additional information that you think would be helpful when reviewing this
PR.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/committers

@rosiel
Copy link
Member

rosiel commented Jul 10, 2023

I'm approving. The use here of accessCheck(FALSE) makes far more sense than the status-quo alternative.

@rosiel rosiel merged commit 6f2d837 into 2.x Jul 19, 2023
@rosiel rosiel deleted the 27-drupal-10 branch July 19, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants