Add configuration form to remove ?_format=jsonld from @ids

[dannylamb]

GitHub Issue: Islandora/documentation#887

Supersedes #32

What does this Pull Request do?

This is the same code as #32 but on the Foundation's repo so that it can be tested with claw-playbook.

Makes a configuration choice of whether the URIs output by the Drupal normalizer contain the _format=jsonld parameter or not.

I also added a check in the getEntityUrl() for file types, they don't have a canonical link template but for now url() generates a good url.

What's new?

• Added a setting form with a checkbox.

• Does this change require documentation to be updated? included

• Does this change add any new dependencies? no

• Does this change require any other modifications to be made to the repository
  (ie. Regeneration activity, etc.)? no

• Could this change impact execution of existing code? yes, toggling the checkbox could affect how items are serialized out to Fedora/Milliner/Triplestores/Solr.

How should this be tested?

1. Pull down the PR
2. Create a Repository Item (say http://localhost:8000/node/3)
3. View the Json-ld ('http://localhost:8000/node/3?_format=jsonld`)
   • Note all the @ids have ?_format=jsonld on the end
4. Goto http://localhost:8000/admin/config/search/jsonld
5. Check the checkbox and Save the configuration.
6. Reload the above Json-ld
   • Note the @ids no longer have ?_format=jsonld on the end.

Interested parties

@Islandora-CLAW/committers

[whikloj]

@dannylamb You are missing the remove_jsonld_format from the install config schema.

[dannylamb]

But it is there... I must be missing something subtle here.

[whikloj]

@dannylamb do the tests pass if you run them locally?

[dannylamb]

Nope, they don't run locally. I added the schema file as a precaution because I know it's finicky about this sort of stuff 😢 I just can't figure out what I'm doing wrong.

They do run just fine if I give it a little

  protected static $configSchemaCheckerExclusions = [
    'jsonld.settings',
  ];

but that feels like cheating.

[whikloj]

@dannylamb I'll try to pull this into my claw-playbook and see if I can help

[dannylamb]

@whikloj pfft.... it's boolean and not bool. wow.

[dannylamb]

[dannylamb]

Updating installer accordingly...

[dannylamb]

aaaaaand done. Now we're properly using boolean when drush cseting as well.

[dannylamb]

FYI https://www.drupal.org/project/config_inspector FTW

[seth-shaw-unlv]

Anything need doing before I click merge?

[whikloj]

I don't think so.

…

On Mon., May 20, 2019, 16:41 Seth Shaw, ***@***.***> wrote: ***@***.**** approved this pull request. [image: ] Anything need doing before I click merge? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#33>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAVZVYNUFWBIAE5472HJKTDPWMEIFANCNFSM4HNDIYKQ> .