Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer replace islandora/jsonld #77

Closed
wants to merge 5 commits into from
Closed

Composer replace islandora/jsonld #77

wants to merge 5 commits into from

Conversation

rosiel
Copy link
Member

@rosiel rosiel commented May 28, 2024

GitHub Issue: Islandora/documentation#2270

What does this Pull Request do?

Says this repo replaces islandora/jsonld; useful when we're getting it as drupal/jsonld.

Also corrects the testing matrix.

Additional Notes:

Any additional information that you think would be helpful when reviewing this
PR.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/committers

@seth-shaw-asu
Copy link
Member

The tests began failing with the move from 10.2.4 to 10.2.5 due to this line:

This command will dump the value of the array to the screen and then kills the process. Apparently up through D10.2.4 it would prevent it from dying and still execute the assertEquals, but now it doesn't. Remove that line (it isn't necessary, it was just useful in debugging tests) and the tests will pass.

@seth-shaw-asu
Copy link
Member

This command will dump the value of the array to the screen and then kills the process. Apparently up through D10.2.4 it would prevent it from dying and still execute the assertEquals, but now it doesn't. Remove that line (it isn't necessary, it was just useful in debugging tests) and the tests will pass.

Oddly enough, looking at this some more, the dump() function call should work. Drupal core has a test for this that passes in my testing, so it should work for us too. I don't know why it isn't. But, again, we don't actually need it, so purging it is fine.

@rosiel
Copy link
Member Author

rosiel commented May 29, 2024

This is breaking Packagist; a package cannot replace itself.

@rosiel rosiel closed this May 29, 2024
@rosiel rosiel deleted the composer-replace branch May 29, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants