Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused dependency on libraries. #34

Merged
merged 2 commits into from
Dec 10, 2020

Conversation

jordandukart
Copy link
Member

GitHub Issue: Islandora/documentation#1729

  • Other Relevant Links (Google Groups discussion, related pull requests,
    Cdn #26

What does this Pull Request do?

As part of a previous issue Openseadragon was made to pull in off of a CDN. Libraries wasn't fully ripped out and is no longer required. If we wanted to support libraries still (D9 or not) we could circle back and look at https://www.drupal.org/node/3099614.

What's new?

Removal of a dependency that is no longer used.

How should this be tested?

  • Ingest an image with Openseadragon as the viewer
  • Verify it's viewable
  • Pull this code and clear the cache
  • Still viewable

Interested parties

@elizoller @dannylamb

Copy link
Contributor

@dannylamb dannylamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Yessir. Tested and openseadragon is still there. Nothing like an all red PR 🔥

@dannylamb dannylamb merged commit 1401a03 into Islandora:8.x-1.x Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants