Make path to openseadragon images protocol relative #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My understanding is that #26 means that the JS library is being loaded from a CDN. This PR would revert that change, which would probably not want to do. If we want to provide the option for folks to use a locally hosted library, then I think it would need to be a configuration option that is added to allow a person to switch between CDN and a locally hosted library and if they chose locally hosted, then yes the library URL should be the same protocol. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: Islandora/documentation#1504
What does this Pull Request do?
Adds the same
file_url_transform_relative()from #25 toopenseadragon_iiif_manifest_block.What's new
Wrap
file_create_url()withfile_url_transform_relative().How should this be tested?
Visit a Repository Item page on a site served by https and observe mixed content warnings in browser console. Apply patch. Reload page and observe no mixed content warnings.
Additional Notes:
This may be superseded by #26 - but we have found it useful as a workaround for now.
Interested parties
@Islandora/8-x-committers