Attach the JS libraries using the preprocess and not in the template. #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elizoller
approved these changes
Oct 26, 2021
There was a problem hiding this comment.
I tested on a new playbook build, recreated the console error described in Islandora/documentation#1975 and then pulled in this branch and cache clear and console error gone. Confirmed OSD block and regular OSD view mode both work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: Islandora/documentation#1975
What does this Pull Request do?
Includes the JS libraries in the preprocess implementations as opposed to the template. This fixes a bug that can occur when viewing a object with the block being rendered where there are no tilesources.
What's new?
Errors don't pop in the console, libraries are attached a different way.
How should this be tested?
Can reproduce the existing bug using what's documented in Islandora/documentation#1975.
Beyond that the OSD should behave as it did before when viewing things.
Interested parties
@Islandora/8-x-committers