Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial todo api spec #1

Merged
merged 4 commits into from
Aug 5, 2024

Conversation

elmerbulthuis
Copy link

No description provided.

@IsraelOjiefoh
Copy link
Owner

Thank you!, I was already learning about how open API works a while ago, so seeing the API specifications for the todo was very clear, I had already started writing the specifications.

The area I'll need more clarity on is in the generate.js file,
Screenshot 2024-08-03 160638
Based on the image I attached, it says: "skiffa-generator' is not recognized as an internal or external command," while pointing to the newly added todo-api.yaml file. Is there something else I'm not doing?

@elmerbulthuis
Copy link
Author

Yes! That was my mistake!

The generate script generates code and then installs dependencies for the generated code, but only for the generated code! The generator (skiffa-generator) is not part of the generated code. So it is actually uninstalled when we install the generated code!

generate.js does not try to install anything now. The initialize script does this.

The initialize installe dependencies of the root workspace first, including the generator, then generates the code and finally installs the entire repo.

\o/

@elmerbulthuis elmerbulthuis changed the base branch from main to example August 4, 2024 08:58
Copy link
Owner

@IsraelOjiefoh IsraelOjiefoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! i'll merge now

@IsraelOjiefoh IsraelOjiefoh merged commit d554557 into IsraelOjiefoh:example Aug 5, 2024
@elmerbulthuis elmerbulthuis deleted the todo-setup branch August 5, 2024 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants