PBS alloc checker #381
Open
PBS alloc checker #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User3574
force-pushed
the
hq_autoalloc_check
branch
from
3d0501f to
be617d4
Compare
Kobzol
requested changes
Mar 4, 2022
There was a problem hiding this comment.
The check has to be performed on the server, not on the client, because the client might not even have PBS available (or it might be a different PBS than on the server). Therefore we also need to return the error in a different way rather than logging it.
Currently, returning errors is quite basic in the client/server RPC, it would be really nice to use e.g. tarpc or some better RPC approach to solve this first.
| match get_value_by_key_json(queue, String::from(backlog)) { | ||
| Ok(value) => Some( | ||
| value | ||
| .to_string() |
There was a problem hiding this comment.
Why is this is_numeric filter here? What data is returned by PBS here?
There was a problem hiding this comment.
Backlog has specific format in our qstat: "max_queued":"[u:PBS_GENERIC=5]"
User3574
force-pushed
the
hq_autoalloc_check
branch
from
eda6703 to
ec9a6e0
Compare
Kobzol
requested changes
Mar 9, 2022
User3574
force-pushed
the
hq_autoalloc_check
branch
from
5d6dab7 to
167715c
Compare
Kobzol
force-pushed
the
main
branch
5 times, most recently
from
5de53cd to
4f5c720
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #174