Zadanie na druhy tyzden #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmikeska
commented
Nov 18, 2018
tmikeska
commented
- doplneny kod pre services a repo interfaces + ich implementacia
- rozsireny test
rapasoft
reviewed
Nov 19, 2018
|
|
||
| @Override | ||
| public Post createNewPost(Post post) { | ||
| return postRepository.create(post); |
There was a problem hiding this comment.
Treba dat pozor na to, ze Post entita sa sklada z viacerych komplexnych objektov (Author, Category), cize obycajne delegovanie na repozitar nie je dostatocne. PostService bude pravdepodobne musiet mat dalsie zavislosti, ktore umoznia vytvorit autora alebo kategoriu.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.