[MOB-10588] release-2-0-0-beta #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
…act-native-sdk into MOB-10588-release-2-0-0-beta * 'MOB-10588-release-2-0-0-beta' of github.com:Iterable/react-native-sdk: docs: added common error to readme fix: removed indicator chore: removed console statement
|
Code Climate has analyzed commit 324aa31 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 37.9% (0.0% change). View more on Code Climate. |
Ayyanchira
approved these changes
Jan 29, 2025
| - Removed broken integration tests | ||
| - Changed folder structure to prepare for it to be divided into multiple packages | ||
| - Removed duplicate code | ||
| - Made lint rules stricter |
There was a problem hiding this comment.
This is the one repeated as mentioned ⬆️
| - [react-native-vector-icons](https://github.com/oblador/react-native-vector-icons) | ||
| - [react-native-webview](https://github.com/react-native-webview/react-native-webview) | ||
| - Update exports to include components which previously were obtained via direct | ||
| path. EG: Instead of `import IterableInbox from |
There was a problem hiding this comment.
examples for breaking changes are indeed helpful 👍🏼
| - **NOTE**: This is a breaking change. All nested imports will need to be updated. | ||
| - Replaced non-working sample application with a new example app | ||
| - Changed scaffolding to use [react-native-builder-bob](https://callstack.github.io/react-native-builder-bob/create) | ||
| - Fixed linting issues and made lint rules stricter |
There was a problem hiding this comment.
Made lint rules stricter is mentioned below as well.
evantk91
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔹 JIRA Ticket(s) if any
✏️ Description