-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deploy start & success notifications & multiple slack channel support #7
Conversation
Add git username + environment link
Awesome idea! |
Add git username, git commit link & simplify message
Add support for multiple Slack orgs/channels
@tangrufus I've updated this a little further as Slack now doesn't allow one webhook to post to multiple channels, at least when creating a new App. My changes allow a channel to be notified per site, per environment, as well as notifying multiple channels per deploy (Mike's change). I've also moved the slack deploy token to vault. There's a PR up for @mike-sheppard here (#3) - I figured it was best to merge into his changes first but I can PR direct if that's easier. Feedback welcome from all 👍 |
@dalepgrant I'd definitely prefer merging the work from you and @mike-sheppard in one to simplify tagging the next release - so hopefully we can move forward with that. |
@codepuncher happy to help, let me know if you need anything more from me. Same to you @mike-sheppard 👍 |
@dalepgrant I can see that you've submitted a PR here, so I guess we'll just wait to hear back from @mike-sheppard |
Sure thing, that should be sorted now 👍🏻 |
Move deploy webhooks to vault and allow different webhooks per site
Cheers, @mike-sheppard. I'll try and get this tested this week. Thanks again for the PR! |
Co-authored-by: Lee Hanbury <lee.hanbury@gmail.com>
Hey @codepuncher any issues during testing? Let me know if I can do anything to get this merged in. Nice one! |
Summary
Preview