Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deploy start & success notifications & multiple slack channel support #7

Closed
wants to merge 27 commits into from

Conversation

mike-sheppard
Copy link

@mike-sheppard mike-sheppard commented Feb 21, 2020

Summary

Preview

deployment-screenshot

tasks/deploy_start.yml Show resolved Hide resolved
tasks/deploy_success.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@tangrufus
Copy link
Contributor

Awesome idea!

@mike-sheppard mike-sheppard changed the title Add deploy start, success and git username to slack notifications Add deploy start & success notifications & multiple slack channel support May 17, 2020
@dalepgrant
Copy link

@tangrufus I've updated this a little further as Slack now doesn't allow one webhook to post to multiple channels, at least when creating a new App. My changes allow a channel to be notified per site, per environment, as well as notifying multiple channels per deploy (Mike's change). I've also moved the slack deploy token to vault. There's a PR up for @mike-sheppard here (#3) - I figured it was best to merge into his changes first but I can PR direct if that's easier.

Feedback welcome from all 👍

README.md Outdated Show resolved Hide resolved
@codepuncher
Copy link
Member

@dalepgrant I'd definitely prefer merging the work from you and @mike-sheppard in one to simplify tagging the next release - so hopefully we can move forward with that.

@dalepgrant
Copy link

@codepuncher happy to help, let me know if you need anything more from me.

Same to you @mike-sheppard 👍

@codepuncher
Copy link
Member

@dalepgrant I can see that you've submitted a PR here, so I guess we'll just wait to hear back from @mike-sheppard

@mike-sheppard
Copy link
Author

Sure thing, that should be sorted now 👍🏻

Move deploy webhooks to vault and allow different webhooks per site
@codepuncher
Copy link
Member

Cheers, @mike-sheppard. I'll try and get this tested this week. Thanks again for the PR!

README.md Outdated Show resolved Hide resolved
Co-authored-by: Lee Hanbury <lee.hanbury@gmail.com>
@mike-sheppard
Copy link
Author

Hey @codepuncher any issues during testing? Let me know if I can do anything to get this merged in.

Nice one!
Mike

@mike-sheppard mike-sheppard deleted the branch ItinerisLtd:master July 15, 2024 20:21
@mike-sheppard mike-sheppard deleted the master branch July 15, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants