Optimize startup time #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JavaNCSS is no longer maintained and stopped its support to Java 7... Change-Id: I900e36f2dfc9f5b9746d5bc9afc3987a6314113b
listJar() is a method that returns a list of files contained within a Jar file according to a glob pattern. It used to rely on a ZipInputStream that needs to read the entire file to discover its content. Now switched to a ZipFileSystem that is able to use the Central Directory at the end of the file directly to list contained files, therefore it is by order of magnitude faster. Change-Id: Idecd9c512fc878d13e04f60d9500173b26220db0
benoitdesire
approved these changes
Aug 16, 2023
benoitdesire
approved these changes
Aug 16, 2023
xdaragon
approved these changes
Aug 25, 2023
xdaragon
approved these changes
Aug 25, 2023
xdaragon
approved these changes
Aug 25, 2023
dfev77
reviewed
Aug 28, 2023
capsule-util/src/test/java/co/paralleluniverse/capsule/CapsuleLauncherTest.java
Show resolved
Hide resolved
Manually generate a file name rather than using Files.createTempFile() since this latter queries network interfaces which takes more time than a good old System.nanotime(). Change-Id: Ib1e8765f010e8332e882b77d5a6ccac1d4860b9e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize listJar() method
listJar() is a method that returns a list of files contained within a Jar file according to a glob pattern.
It used to rely on a ZipInputStream that needs to read the entire file to discover its content.
Now switched to a ZipFileSystem that is able to use the Central Directory at the end of the file directly to list contained files, therefore it is by order of magnitude faster.
Optimize pathing jar generation
Manually generate a file name using regular Random rather than using Files.createTempFile() since this latter uses SecuredRandom which itself queries network interfaces which takes more time than a good old System.nanotime() of Random.