fix permission check #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confirmed to be working on my end. Thanks @zWyzzzzz |
ItsANoBrainer
requested changes
Mar 20, 2022
There was a problem hiding this comment.
I would like to see the permission level check being done inside OpenMenu function (since its called multiple places), and ToggleDeletionLaser. Seems kind of odd you need permission to create one, but not delete it. If that's not ideal, then a separate config option to disable the permission on both would be an alternative.
Comment on lines
+108
to
+110
| QBCore.Functions.TriggerCallback('qb-scenes:server:GetPermissions', function(permission) | ||
| permissionLevel = permission | ||
| end) |
There was a problem hiding this comment.
Since we're using this more than once, we should move this to a function that can be called.
Co-authored-by: ItsANoBrainer <itsanobrainergg@protonmail.com>
Co-authored-by: ItsANoBrainer <itsanobrainergg@protonmail.com>
Co-authored-by: ItsANoBrainer <itsanobrainergg@protonmail.com>
Co-authored-by: ItsANoBrainer <itsanobrainergg@protonmail.com>
Co-authored-by: ItsANoBrainer <itsanobrainergg@protonmail.com>
|
idk, i try this one but all player still can use scene menu. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.