Add unique toast and show inside Ui supports #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could describe some use cases for a |
For example: show and clip the notify in a window or panel. |
|
EDIT: or it actually could be that top margin is missing for some reason. |
ItsEthra
requested changes
Oct 26, 2023
src/toast.rs
Outdated
| @@ -61,6 +94,7 @@ pub struct Toast { | |||
|
|
|||
| pub(crate) state: ToastState, | |||
| pub(crate) value: f32, | |||
| pub(crate) id: Option<String>, | |||
There was a problem hiding this comment.
I don't think it's great idea to use String as Id type as it requires allocation. It's probably better to use egui::Id that already uses a hash function.
src/lib.rs
Outdated
| if let Some(ref id) = toast.id { | ||
| if let Some(i) = self.toasts.iter().position(|t| t.id.as_ref() == Some(id)) { | ||
| let exist = self.toasts.get_mut(i).unwrap(); | ||
| exist.level = toast.level; |
There was a problem hiding this comment.
Why assign fields individually instead of just assigning the whole struct? Like *exist = toast
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New features:
idto Toast, could be use a unique id to update an exists toast.show_inside()to Toasts, could be limit the display rect to Ui.