fix(server): correct improper Close operation. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We CANNOT close the stream immediately as we act as the data carrier in the middle. This fix ensures proper data flow through the relay.
|
实测Firefox全部使用Websockets的网站全部恢复正常，Chrome（感觉上）快了一点。 |
|
备注：Firefox版本129 |
|
建议找一下具体的错误类型，添加一个match分支。严重的、不可恢复的错误还是要直接close的。 |
这个我来做吧 |
ghost
mentioned this pull request
Closed
|
目前该pr的修改已被撤销， |
|
好，这个问题确实应该是singbox的tuic实现出了问题 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
碰到连接错误给链路关了做甚，给Firefox都整不会了，只是探测一下支不支持Websockets Over HTTP/2，结果一下给整个TCP连接关了？
修复：
#10