Minor refactor steps calculation #50
Open
+13
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-le
commented
Jun 25, 2024
robot-le
commented
- Remove the extra if...else statement to make the code more DRY
- Conduct some minor typo edits
- Change relative imports to absolute
added 2 commits
June 25, 2024 18:05
It seems like some variables wasn't used since the first commits, so I removed them. Additionally, changed relative imports to absolute and corrected typos in comment and function name.
|
Also, I have a question about the file GUI_template.py. If I understand correctly, this code is needed for opening the GUI map before changing the display map way to open it in the browser. Do I get it right that this file is no longer needed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.