Skip to content

Commit

Permalink
Update clap to 3.2 in tools using value_parser (bevyengine#5031)
Browse files Browse the repository at this point in the history
**Why?**
The `value_parser` `clap` attribute was added in
[version 3.2.0][0]. With the current version of `3.1.12` users can get
errors like:

```
error: unexpected attribute: value_parser
  --> tools/spancmp/src/main.rs:18:25
   |
18 |     #[clap(short, long, value_parser, default_value_t = 0.0)]
   |                         ^^^^^^^^^^^^
```

See bevyengine#4944 (comment) for more details.

[0]: https://github.com/clap-rs/clap/blob/master/CHANGELOG.md#320---2022-06-13
  • Loading branch information
mlodato517 authored and inodentry committed Aug 8, 2022
1 parent ee3474b commit e771ab1
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion tools/build-wasm-example/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,4 @@ license = "MIT OR Apache-2.0"

[dependencies]
xshell = "0.2"
clap = { version = "3.1.12", features = ["derive"] }
clap = { version = "3.2", features = ["derive"] }
2 changes: 1 addition & 1 deletion tools/spancmp/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ license = "MIT OR Apache-2.0"
[dependencies]
serde_json = "1.0"
serde = { version = "1.0", features = ["derive"] }
clap = { version = "3.1.12", features = ["derive"] }
clap = { version = "3.2", features = ["derive"] }
regex = "1.5"
termcolor = "1.1"
bevy_reflect = { path = "../../crates/bevy_reflect", version = "0.8.0-dev" }
Expand Down

0 comments on commit e771ab1

Please sign in to comment.