Fix build errors in SuperSlicer #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Address various build issues and errors in the project. * **MASM-Related Errors**: Modify `src/angelscript/CMakeLists.txt` to exclude unsupported flags for assembly files by adding `set_source_files_properties` for relevant assembly files. * **Invalid CMake Configuration**: Update `CMakeLists.txt` to include `cmake_policy(SET CMP0175 NEW)`. * **Missing Dependencies**: Ensure submodules are updated by initializing submodules recursively in `.github/workflows/ccpp_ubuntu.yml` and `.github/workflows/ccpp_win_debug.yml`. * **PowerShell Script Issues**: Add steps in `.github/workflows/ccpp_win_debug.yml` to replace +UNKNOWN with a date in `version.inc` only if the file exists. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/J-DRD/SuperSlicer?shareId=XXXX-XXXX-XXXX-XXXX).
J-DRD
added a commit
that referenced
this pull request
Nov 16, 2024
J-DRD
added a commit
that referenced
this pull request
Nov 16, 2024
Address various build issues and errors in the project. * **MASM-Related Errors**: Modify `src/angelscript/CMakeLists.txt` to exclude unsupported flags for assembly files by adding `set_source_files_properties` for relevant assembly files. * **Invalid CMake Configuration**: Update `CMakeLists.txt` to include `cmake_policy(SET CMP0175 NEW)`. * **Missing Dependencies**: Ensure submodules are updated by initializing submodules recursively in `.github/workflows/ccpp_ubuntu.yml` and `.github/workflows/ccpp_win_debug.yml`. * **PowerShell Script Issues**: Add steps in `.github/workflows/ccpp_win_debug.yml` to replace +UNKNOWN with a date in `version.inc` only if the file exists. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/J-DRD/SuperSlicer?shareId=XXXX-XXXX-XXXX-XXXX).
J-DRD
added a commit
that referenced
this pull request
Nov 16, 2024
J-DRD
added a commit
that referenced
this pull request
Nov 16, 2024
Address various build issues and errors in the project. * **MASM-Related Errors**: Modify `src/angelscript/CMakeLists.txt` to exclude unsupported flags for assembly files by adding `set_source_files_properties` for relevant assembly files. * **Invalid CMake Configuration**: Update `CMakeLists.txt` to include `cmake_policy(SET CMP0175 NEW)`. * **Missing Dependencies**: Ensure submodules are updated by initializing submodules recursively in `.github/workflows/ccpp_ubuntu.yml` and `.github/workflows/ccpp_win_debug.yml`. * **PowerShell Script Issues**: Add steps in `.github/workflows/ccpp_win_debug.yml` to replace +UNKNOWN with a date in `version.inc` only if the file exists. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/J-DRD/SuperSlicer?shareId=XXXX-XXXX-XXXX-XXXX).
J-DRD
added a commit
that referenced
this pull request
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address various build issues and errors in the project.
src/angelscript/CMakeLists.txtto exclude unsupported flags for assembly files by addingset_source_files_propertiesfor relevant assembly files.CMakeLists.txtto includecmake_policy(SET CMP0175 NEW)..github/workflows/ccpp_ubuntu.ymland.github/workflows/ccpp_win_debug.yml..github/workflows/ccpp_win_debug.ymlto replace +UNKNOWN with a date inversion.inconly if the file exists.For more details, open the Copilot Workspace session.