Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pandas deprecation warning #99

Closed
0x26res opened this issue May 30, 2019 · 2 comments · Fixed by #103
Closed

Pandas deprecation warning #99

0x26res opened this issue May 30, 2019 · 2 comments · Fixed by #103

Comments

@0x26res
Copy link

0x26res commented May 30, 2019

I get this warning when running recordlinkage 13.2 with pandas 24.2

recordlinkage/base.py:288: FutureWarning: .labels was deprecated in version 0.24.0. Use .codes instead.

To avoid the warning (and the future error) the code should be updated. I don't think using codes is backward compatible though.

I think we can use this issue (and the related PR) for inspiration: https://github.com/apache/arrow/pull/3120/files

I'm happy to help/submit a PR.

@J535D165
Copy link
Owner

J535D165 commented Jun 9, 2019

Thanks @arthurandres, fixed in PR #103

For reference: pandas-dev/pandas#13443

@0x26res
Copy link
Author

0x26res commented Jun 10, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants