Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve console and font handling #1184

Merged
merged 8 commits into from
Feb 8, 2024
Merged

Conversation

Daggolin
Copy link
Contributor

@Daggolin Daggolin commented Nov 6, 2023

This pull request aims to slightly improve the console behavior.

  1. It replaces the SDLK_CARET shift-requirement when trying to open the console in scancode mode (cl_consoleUseScanCode) with the cvar check from jk2mv: cl_consoleShiftRequirement (prefixed mv_ instead of cl_ on jk2mv).

  2. It adds a cvar to set the height of the console: con_height.

…ith a check for cl_consoleShiftRequirement.

The cvar cl_consoleShiftRequirement matches the jk2mv mv_consoleShiftRequirement:
 - 0: no shift key required
 - 1: shift required to open the console
 - 2: shift required to open and close the console
@Daggolin Daggolin requested a review from a team as a code owner November 6, 2023 23:24
This includes con_scale, con_timestamps, changes to line wrapping, condump, ...

Most of these changes were originally written by fau and have more context within the jk2mv repository.
…nal and qconsole.log

Originally written by fau for jk2mv.
…efault fonts and dynamically register them to avoid undesired font changes when registering other fonts too early.
…fontSharpness).

Originally written by fau for jk2mv.
@Daggolin
Copy link
Contributor Author

Added additional features and fixes to this pull request:

  1. Console features from jk2mv (con_scale, con_timestamp, ...).

  2. Terminal and qconsole.log timestamps (cvar: com_timestamps).

  3. Fix ocr_a font disappearing from consoles on renderer restart.

  4. Fix UI module using incorrect font handles.

  5. Support for sharper fonts (cvar: r_fontSharpness).

@Daggolin Daggolin changed the title Improve console handling Improve console and font handling Nov 12, 2023
@Razish Razish merged commit 01697e6 into JACoders:master Feb 8, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants