-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New d1s libraries support (93c) #306
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Davide. Comments relate to minor updates to documentation. In the future we may think to include different irradiation scenarios (DT1) for sphere SDDR. Though I believe even with ITER rebaseline, SA2 is still reference safety scenario?
,,F32-0.0005,2.2875,Ordinary Concrete,M200,True | ||
,,F32-0.0005,2.33,Natural Silicon,M900,True | ||
,,F32-0.0005,0.93,Polyethylene (non-borated),M901,True | ||
,,F32-0.0005,9,Tungsten,M74,TRUE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The density reduction in tungsten is presumably to make the simulation more straightforward?
The docs should be updated in the 'Default Benchmarks' description of the sphere to include Tungsten in the list of materials. This density reduction could be noted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I thought it was a good idea to reduce the density otherwise we most likely would have had a very low leakage flux. This is not the first time we do something like that, at least not in the single isotopes. Uranium is one example. I will add a few lines in the doc. With regard to the adding of DT1: sure, we will have to rethink a bit some of the benchmarks due to the rebaseline. Like maybe update the ITER 1D benchmark and even C-model maybe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments as for sphere leakage MaterialsSettings.csv
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only note here is that I can not find these 'irrad _x' files documented. Reference is made to the activation library but the library should perhaps be referenced (decay2020?).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, I believe these are not properly described. I will see to add something somewhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comments addressed. Thanks Davide
Description
The aim of this PR is to add the new D1S library information (93) to JADE:
Type of change
Please select what type of change this is.
Testing
Manual test has been conducted
Checklist: