Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New d1s libraries support (93c) #306

Merged
merged 5 commits into from
Jul 22, 2024

Conversation

dodu94
Copy link
Member

@dodu94 dodu94 commented Jul 3, 2024

Description

The aim of this PR is to add the new D1S library information (93) to JADE:

  • The list of all possible reactions for the new library has been added to the Activation file
  • suitable irrad file has been created for the SphereSDDR benchmark
  • Tungsten support has been added for the Typical Materials (not active until the TypicalMaterial file is changed on the IAEA repo)

Type of change

Please select what type of change this is.

  • Bug fix (non-breaking change which fixes an issue)
  • New benchmark
    • Non-breaking change which entirely uses exisiting classes, structure etc
    • Breaking change which has implemented new/modified classes etc
  • New feature
    • Non-breaking change which adds functionality
    • Breaking change fix or feature that would cause existing functionality to not work as expected

Testing

Manual test has been conducted

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • General testing
    • New and existing unit tests pass locally with my changes
    • Coverage is >80%

@dodu94 dodu94 marked this pull request as ready for review July 4, 2024 15:20
@dodu94 dodu94 requested a review from alexvalentine94 July 4, 2024 15:20
Copy link
Collaborator

@alexvalentine94 alexvalentine94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Davide. Comments relate to minor updates to documentation. In the future we may think to include different irradiation scenarios (DT1) for sphere SDDR. Though I believe even with ITER rebaseline, SA2 is still reference safety scenario?

,,F32-0.0005,2.2875,Ordinary Concrete,M200,True
,,F32-0.0005,2.33,Natural Silicon,M900,True
,,F32-0.0005,0.93,Polyethylene (non-borated),M901,True
,,F32-0.0005,9,Tungsten,M74,TRUE
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The density reduction in tungsten is presumably to make the simulation more straightforward?
The docs should be updated in the 'Default Benchmarks' description of the sphere to include Tungsten in the list of materials. This density reduction could be noted.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I thought it was a good idea to reduce the density otherwise we most likely would have had a very low leakage flux. This is not the first time we do something like that, at least not in the single isotopes. Uranium is one example. I will add a few lines in the doc. With regard to the adding of DT1: sure, we will have to rethink a bit some of the benchmarks due to the rebaseline. Like maybe update the ITER 1D benchmark and even C-model maybe.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments as for sphere leakage MaterialsSettings.csv

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only note here is that I can not find these 'irrad _x' files documented. Reference is made to the activation library but the library should perhaps be referenced (decay2020?).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, I believe these are not properly described. I will see to add something somewhere

Copy link
Collaborator

@alexvalentine94 alexvalentine94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments addressed. Thanks Davide

@alexvalentine94 alexvalentine94 merged commit eeacb1b into developing Jul 22, 2024
8 checks passed
@dodu94 dodu94 deleted the New-d1s-libraries-support-(93c) branch July 22, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants