Remove DOM hooks from document #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAForbes
reviewed
Apr 19, 2024
lib/index.ts
Outdated
| if (options?.server) { | ||
| return | ||
| } | ||
|
|
||
| (vnode.dom as any).parentNode.classList.add(parsed.hash) | ||
| (parentNode as HTMLElement).classList.add(parsed.hash) |
There was a problem hiding this comment.
I seem to remember in the past, removing this node caused mithril to get confused about the vtree state later on. It would try to unmount the node and then crash because the node wasn't there.
Maybe if we add a JSDOM test that unmounts the css node and see if mithril freaks out or not.
JAForbes
reviewed
Apr 19, 2024
| @@ -48,9 +48,6 @@ test('server', async () => { | |||
| assertStringEq( | |||
| pretty([...sheets.values()].join('')), | |||
| pretty(` | |||
| css-node { | |||
| display: none; | |||
| } | |||
There was a problem hiding this comment.
Should we still hide it for that short interval between first render and oncreate?
JAForbes
approved these changes
Apr 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
css-nodeelements are only there to get a hold of their parents, and they're just a liability after that (breaking positional structure like:only-childetc).Tried to write a test to account for bug case but JSDOM wasn't playing ball and whatever TBH