Enable sorting commands in designer #75
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is definitely the need to allow sorting commands in the Ribbon Designer. I opened issue #76 for this. I think I'm gonna play a little with possible implementations as I see some room for enhancement in you pull request. But thanks for sending it. |
|
I'm sorry for late response. And Thank you for checking my pull request. We looking forward to add this function by you, Maybe We will send other pull request for you about other point. If we need. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Mr.Eric
Thank you for developing valuable framework. Our project has a lot of commands (like figure in bottom). In this situation, the function of sorting commands in designer is useful for us. So I added this function to designer. So Please merge my change to your branch. If you think that my change is acceptable.
Designer don't ask the user save changes to xml file in the case that the user only sort commands. Designer ask the user save changes to xml file in the case that the user sort commands and use "Move command" command. The reason of this specification is that I think most of users don't want to save the result of sorting command.