Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pre-commit documentation #16

Merged
merged 1 commit into from
Nov 17, 2022
Merged

Update pre-commit documentation #16

merged 1 commit into from
Nov 17, 2022

Conversation

chimaerase
Copy link
Collaborator

This PR should be reviewed / merged after #14, which applied basic formatting changes to the entire README file.

Update pre-commit documentation

  1. Use pre-commit to install & run black, flake8, etc

Pre-commit tool versions will diverge between projects, so installing / running them from a single shared install in the system Python will lead to unexpected failed commits

  1. Add Advanced.md

Existing reference to ART's pre-commit documentation is broken following recent updates to ART. Copied relevant commands here to make DemoRepo self-contained. Also added suggested workflow for ignoring commit hooks when necessary, though "highly discouraged" & purposefully buried at the end of this advanced document.

1. Use pre-commit to install & run black, flake8, etc

Pre-commit tool versions will diverge between projects, so installing / running them from a single shared install in the system Python will lead to unexpected failed commits

2. Add Advanced.md

Existing reference to ART's pre-commit documentation is broken following recent updates to ART. Copied relevant commands here to make DemoRepo self-contained. Also added suggested workflow for ignoring commit hooks when necessary, though "highly discouraged" & purposefully buried at the end of this advanced document.
@chimaerase chimaerase merged commit 05c230c into main Nov 17, 2022
@chimaerase chimaerase deleted the pre-commit branch November 17, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants