Improved removal of useless rules when creating schemas #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separated the unnecessary rule removal logic from the SchemaDataPrep class and moved it into a new class called RuleOptimizer for better organization and readability. This also updates references to this logic in existing code and tests, leading to overall performance improvements in validation rule preparation.
Simplified the existing 'analyzeColumns' number validation sections in Analyzer.php and RuleOptimizer.php, reducing code redundancy and enhancing readability. Moved schema validation from Analyzer to CreateSchema to allow schema check flexibility from the UI, improving the usability of the codebase.
The code handling numeric type fixing (`is_int` and `is_float`) has been moved to its own function `fixNumericTypes`. This separation enhances readability and modularizes the function, allowing for easier code modifications in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.