Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev/master ecbuild sync #5

Merged
merged 550 commits into from
Aug 19, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
550 commits
Select commit Hold shift + click to select a range
2260e70
Fixed some coding mistakes from the last commit.
sdbachman Apr 12, 2019
317f91b
Merge pull request #908 from jkrasting/user/jpk/trap-kd-turb
Hallberg-NOAA Apr 12, 2019
6542122
Added new variable FrictWork_diss to account for the energy dissipate…
sdbachman Apr 12, 2019
e5238f5
Merge branch 'dev/ncar' into add_nuopc_cap
gustavo-marques Apr 15, 2019
8df6efd
Added a new flag to MOM_lateral_mixing_coeffs called "USE_VISBECK", w…
sdbachman Apr 16, 2019
69e6d30
Re-factor of Travis-CI usage
adcroft Apr 16, 2019
265d01b
Set ca13csed to zero at k>1
jkrasting Apr 11, 2019
8ade0a6
Merge pull request #910 from jkrasting/zero_out_13C_cased
adcroft Apr 17, 2019
91c8083
Merge pull request #909 from adcroft/travis-stages
marshallward Apr 17, 2019
172ae02
Fixed problems with FrictWorkMax and FrictWorkDiss in MOM_hor_visc.F.…
sdbachman Apr 17, 2019
5868144
Merge pull request #93 from gustavo-marques/add_nuopc_cap
alperaltuntas Apr 17, 2019
1175747
+Remove unneeded MOM6 coupler_types.F90 files
Hallberg-NOAA Apr 19, 2019
d892664
Merge branch 'dev-master-candidate-2018-04-22' into merge-dev-master-…
gustavo-marques Apr 23, 2019
acb4d3f
Merge pull request #94 from gustavo-marques/merge-dev-master-candidat…
alperaltuntas Apr 23, 2019
8d92e78
+Added missing US arguments to nuopc_cap code
Hallberg-NOAA Apr 23, 2019
d1ad0dc
Checksum support for Depth_list.nc
marshallward Apr 24, 2019
f95d9eb
Further documentation of Depth_list.nc checksums
marshallward Apr 24, 2019
ce93243
Depth list documentation typo fix
marshallward Apr 24, 2019
379e9ee
make uppercase DEBUG lowercase
alperaltuntas Apr 24, 2019
d8b7825
fix uninitialized oneOrTwo
alperaltuntas Apr 24, 2019
03a5586
Merge branch 'dev/ncar' into fix_debug_mode
gustavo-marques Apr 24, 2019
42582a1
Merge pull request #95 from alperaltuntas/fix_debug_mode
gustavo-marques Apr 24, 2019
4727f20
Merge branch 'dev-master-candidate-2018-04-22' into add_missing_US_ar…
gustavo-marques Apr 24, 2019
ce5571f
Add CS%US argument lost during merge conflict
gustavo-marques Apr 24, 2019
087813d
Masked depth; style conformance
marshallward Apr 24, 2019
61a96a8
Token bugfix
marshallward Apr 24, 2019
36ba339
Merge pull request #96 from gustavo-marques/add_missing_US_arguments_…
alperaltuntas Apr 24, 2019
0fcc576
use ESMF operators
alperaltuntas Apr 24, 2019
3df6ff3
Merge pull request #97 from alperaltuntas/fix_nuopc_use_only
gustavo-marques Apr 24, 2019
51c2a13
Merge branch 'dev-master-candidate-2018-04-22' into dev/master
adcroft Apr 25, 2019
6c32b91
gitlab: specify MOM6-examples and script commits
adcroft Apr 25, 2019
9a1422f
Revert masking of depth
marshallward Apr 25, 2019
0b33904
Bugfix: Checksum the unmasked depth
marshallward Apr 25, 2019
962c020
Merge pull request #915 from adcroft/xanadu-fms
marshallward Apr 26, 2019
a91c0a5
Merge pull request #914 from marshallward/depth_list_repro
adcroft Apr 26, 2019
c24bfb3
Added Jansen et al. (2015) version of MEKE dissipation. Added an alte…
sdbachman Apr 30, 2019
f6d1c65
Fixed if statement in MOM_MEKE.F90. Added option to use alternative
sdbachman Apr 30, 2019
3c91971
Added option to calculate MKE-to-MEKE energy conversion by GME.
sdbachman Apr 30, 2019
73e89ec
Cleaned up MOM_hor_visc.F90 a bit, especially parts having to do with
sdbachman Apr 30, 2019
6b32174
Added biharmonic option for MEKE viscosity.
sdbachman May 2, 2019
80c65c7
Added a GME sink term to the MEKE budget. Cleaned up MOM_hor_visc.F90.
sdbachman May 3, 2019
a6cd3fe
Commented out thickness diffusivity calls for GME, since it is not
sdbachman May 3, 2019
4d02387
Add seaice_melt and seaice_melt_heat
gustavo-marques May 3, 2019
4db5f4d
Merge branch 'add_missing_fluxes_nuopc' into gme_03may2019
gustavo-marques May 3, 2019
97afc59
MEKE: Prevent div-by-zero by bathyT in beta calc
marshallward May 3, 2019
8c9493c
Merge branch 'unified_coupler_types' of https://github.com/Hallberg-N…
adcroft May 3, 2019
af65692
Add FMS/coupler_types.F90 to build Travis-CI build path
adcroft May 3, 2019
69c21ea
Add missing US entries and fix typos introduced during merge
gustavo-marques May 3, 2019
8486c04
Use xanadu-fms version of MRS in gitlab pipeline
adcroft May 3, 2019
7671d31
get calendar from CESM
alperaltuntas May 3, 2019
4b6ef52
Revert "Added biharmonic option for MEKE viscosity."
sdbachman May 3, 2019
93b57b8
Merge branch 'Hallberg-NOAA-unified_coupler_types' into dev/gfdl
adcroft May 3, 2019
5bc8e9f
Merge branch 'dev/gfdl' of https://github.com/NOAA-GFDL/MOM6 into dev…
marshallward May 3, 2019
27bc6b3
Merge pull request #98 from NCAR/fix_nuopc_calendar
gustavo-marques May 3, 2019
434ff08
Willy was silly.
gustavo-marques May 3, 2019
ef0abe6
Merge branch 'dev/ncar' into gme_03may2019
gustavo-marques May 3, 2019
b503858
Merge pull request #99 from gustavo-marques/add_missing_fluxes_nuopc
alperaltuntas May 3, 2019
1733957
Merge branch 'marshallward-dev/gfdl' into dev/gfdl
adcroft May 6, 2019
434ffe7
Working configuration of MEKE/GME. Has biharmonic MEKE viscosity and a
sdbachman May 6, 2019
4c15159
Added a "next-to_boundary" mask that should help with fixing abnormal…
sdbachman May 6, 2019
4d214cb
MOM_set_diffusivity: OMEGA scaling
marshallward May 6, 2019
eda43c4
Merge branch 'guillermo_putao' into gme_06may2019
gustavo-marques May 6, 2019
9487df0
MOM_set_diffusivity: Rescaling of Omega2, G_Rho0
marshallward May 6, 2019
8461ae1
MOM_set_diffusivity: N, dissipation scaling
marshallward May 6, 2019
ed9d9f1
dissip_N2 dimension update
marshallward May 6, 2019
2015e63
(*)Revised propagate_int_tide code for symmetry
Hallberg-NOAA May 7, 2019
dc35d3a
+(*)Revised the diagnostic subML_N2
Hallberg-NOAA May 7, 2019
62c113e
+Added MIN_SALINITY as a new runtime parameter.
Hallberg-NOAA May 7, 2019
550308c
+Corrected documentation of HALF_STRAT_DEPTH
Hallberg-NOAA May 7, 2019
d927495
+Corrected spelling errors in documentation
Hallberg-NOAA May 7, 2019
3c2f250
MOM_set_diffusivity: dissip scaling
marshallward May 7, 2019
c6580ed
MOM_set_diffusivity scaling: N2, Kd_work diags
marshallward May 7, 2019
be7a416
MOM_set_diffusivity: TKE_to_Kd time rescaling
marshallward May 8, 2019
7bb5365
MOM_set_diffusivity: scaling of ML radiation terms
marshallward May 8, 2019
50a14bf
MOM_set_diffusivity: maxTKE time scaling
marshallward May 8, 2019
f17d5e6
MOM_set_diffusivity: more TKE time scaling
marshallward May 8, 2019
f5f3662
MOM_set_diffusivity time scaling: more params
marshallward May 9, 2019
6db9631
+Added newlines in long parameter descriptions
Hallberg-NOAA May 9, 2019
6d0c938
+Revised writeMessageAndDesc to split long lines
Hallberg-NOAA May 9, 2019
5a59262
* Bugfix: Double diffusive correction to Kd
marshallward May 9, 2019
aafdb78
Add FMS/coupler_types.F90 to build Travis-CI build path
adcroft May 3, 2019
def877a
Use xanadu-fms version of MRS in gitlab pipeline
adcroft May 3, 2019
cdd0638
Merge branch 'dev-master-candidate-2019-04-26' into dev/master
adcroft May 10, 2019
d19bd61
MOM_set_diffusivity LOTW time scaling
marshallward May 10, 2019
d88424e
Merge branch 'dd' into scaling
marshallward May 10, 2019
fb6b8e1
Merge pull request #921 from marshallward/dd
Hallberg-NOAA May 10, 2019
d449d37
Set default of USE_NET_FW_ADJUSTMENT_SIGN_BUG to false in NUOPC cap
gustavo-marques May 10, 2019
075f2bb
Merge branch 'dev/master' into dev/gfdl
adcroft May 10, 2019
ed19740
Merge branch 'dev/gfdl' of github.com:NOAA-GFDL/MOM6 into dev/gfdl
adcroft May 10, 2019
368db7a
MOM_set_diffusivity time scaling: DD, bg diff, zint
marshallward May 10, 2019
b668abf
Merge pull request #100 from gustavo-marques/set_fw_bug_to_false
alperaltuntas May 10, 2019
9a9f3d0
MOM_set_diffusivity time scaling: subroutines
marshallward May 11, 2019
7862de9
MOM_set_diffusivity time scaling: Kd_lay
marshallward May 13, 2019
623842d
Merge branch 'diabatic_aux_cleanup' of https://github.com/Hallberg-NO…
adcroft May 13, 2019
76a6931
MOM_set_diffusivity time scaling: Kd_int
marshallward May 13, 2019
a06cb9c
MOM_set_diffusivity time scaling: Kd_BBl + diag
marshallward May 13, 2019
91d2bcd
Time scaling: entrainment_diffusive kd_(lay|int)
marshallward May 13, 2019
382e035
Merge branch 'Hallberg-NOAA-diabatic_aux_cleanup' into dev/gfdl
adcroft May 13, 2019
af6c7f5
MOM_tidal mixing time scaling: input arguments
marshallward May 13, 2019
bb3e943
MOM_set_diffusivity scaling: use kd scaling factor
marshallward May 13, 2019
492ebb6
Switching from moab to slurm queue scheduler
adcroft May 13, 2019
eb301fe
skip first tstep and double second tstep
alperaltuntas May 14, 2019
0ae751e
apply ocean lag to cesm runs only
alperaltuntas May 14, 2019
9532c7e
User diffusivity time rescaling
marshallward May 14, 2019
df4c255
MOM_set_diffusivity comment/whitespace updates
marshallward May 14, 2019
d2a2516
Merge branch 'dev/gfdl' into scaling
marshallward May 14, 2019
49360d2
Merge pull request #922 from marshallward/scaling
Hallberg-NOAA May 14, 2019
0c44cad
Merge branch 'GMplusBS_final' of https://github.com/MFJansen/MOM6 int…
adcroft May 14, 2019
a572988
Avoid division by zero when Ah_time_scale=0
adcroft May 14, 2019
8797615
Merge pull request #101 from NCAR/ocn_lag
gustavo-marques May 14, 2019
45a706c
Add control of MEKE viscosity scaling to recover old answers
adcroft May 14, 2019
b2ff365
fix ocean lag logic for restart runs
alperaltuntas May 15, 2019
e0a8b9b
Merge pull request #102 from NCAR/ocn_lag
gustavo-marques May 15, 2019
e5a0b82
Merge branch 'GME_10may2019putao' into geometric_putao
sdbachman May 16, 2019
de06f1b
Corrected indentation to fit code style guide
adcroft May 16, 2019
78d2dc3
(*) MOM_mixed_layer_restrat [uv]Dml_diag index fix
marshallward May 16, 2019
c703981
Merge branch 'MFJansen-GMplusBS_final-alt' of https://github.com/adcr…
Hallberg-NOAA May 16, 2019
8242261
Merge branch 'adcroft-MFJansen-GMplusBS_final-alt' into dev/gfdl
Hallberg-NOAA May 16, 2019
806e8d9
Rescaled 20 TKE-related variables
Hallberg-NOAA May 16, 2019
fd077d5
Merge pull request #924 from marshallward/udml_diag
Hallberg-NOAA May 16, 2019
82ce6f9
Merge pull request #925 from Hallberg-NOAA/rescale_TKE_vars
marshallward May 17, 2019
03386c0
Merge branch 'dev/ncar' into merge_GME
gustavo-marques May 17, 2019
3672946
Kd_interface diag unit fix
marshallward May 17, 2019
0435ff3
MOM_vert_friction tau[xy]_bot unit fix
marshallward May 17, 2019
a236032
+Removed hard newlines in get_param calls
Hallberg-NOAA May 18, 2019
6aae509
Merge pull request #926 from marshallward/diagfix
adcroft May 20, 2019
404f591
Merge branch 'Hallberg-NOAA-remove_newlines' into dev/gfdl
adcroft May 20, 2019
eaf8c90
+ Excise of legacy z-interpolated diagnostics
marshallward May 21, 2019
c450cc6
Merge branch 'dev/gfdl' into z_diag_purge
marshallward May 21, 2019
3ee6955
Z_OUTPUT_GRID_FILE parameter obsolescence
marshallward May 21, 2019
56e3613
Updating the MOM_CVMix_KPP code
breichl May 22, 2019
1cb32f3
Changes to MOM_wave_interface
breichl May 22, 2019
7914a4e
Adding ePBL tuning relationships needed to use versions from RH18/RL1…
breichl May 22, 2019
3e56a54
Undo changing default La_depth_ratio from 0.04 to 0.2
breichl May 22, 2019
205a450
Moving new ePBL feature Kd_enhance entirely inside of if-block
breichl May 22, 2019
8024364
Clean-up of previous commit
breichl May 22, 2019
413a849
Setting ePBL enhance_K variables to parameters
breichl May 22, 2019
41cfb68
Merge branch 'marshallward-z_diag_purge' into dev/gfdl
Hallberg-NOAA May 22, 2019
928a242
Merge branch 'user/bgr/OSBL_Updates' of https://github.com/breichl/MO…
adcroft May 23, 2019
e15fa88
Fixing bug to WaveMethod inserted in WaveInterface by previous commit.
breichl May 24, 2019
c8b0af6
Merge branch 'WaveMethodBugFix' into user/bgr/OSBL_Updates
breichl May 24, 2019
1d06bd1
Renaming Elizabeth tracer and sponge to RGC
ElizabethYankovsky May 24, 2019
da98b7c
Merge branch 'user/bgr/OSBL_Updates' of https://github.com/breichl/MO…
adcroft May 24, 2019
53be923
Merge branch 'breichl-user/bgr/OSBL_Updates' into dev/gfdl
adcroft May 24, 2019
faba8cc
Merge branch 'dev/gfdl' of https://github.com/NOAA-GFDL/MOM6 into myw…
ElizabethYankovsky May 29, 2019
99d7252
Adding changes to RGC
ElizabethYankovsky May 30, 2019
71b02d7
+(*) u,v tendendy diagnostic fix
marshallward May 30, 2019
056b05c
(*) speed diagnostic fix on nonsymmetric grids
marshallward May 30, 2019
5eae2ee
Merge branch 'dev/gfdl' into diag_fix
marshallward May 30, 2019
59944eb
Added GEOMETRIC as an option for MEKE. Also added biharmonic MEKE vis…
sdbachman May 30, 2019
3594d53
Merge branch 'merge_GME_17May2019' into geometric_putao
gustavo-marques May 31, 2019
7cfb69b
Merge pull request #931 from marshallward/diag_fix
adcroft May 31, 2019
35eccc0
Ensures that MEKE%Kh_diff is only used when USE_KH_IN_MEKE = True
gustavo-marques Jun 3, 2019
3d997ee
Fixes doxygen syntax
gustavo-marques Jun 3, 2019
4dd50c1
Fixes additional doxygen syntax
gustavo-marques Jun 3, 2019
1388ce7
Removes trailing space
gustavo-marques Jun 3, 2019
b3c0b69
Fixes unregistered diagnostic id
gustavo-marques Jun 4, 2019
585a500
Edited RGC_tracer.F90
ElizabethYankovsky Jun 4, 2019
e9f95e4
dKEdt diagnostic nonsymmetric bugfix
marshallward Jun 4, 2019
f52375b
Changes logic of an if statement in calc_slope_functions to avoid cha…
gustavo-marques Jun 6, 2019
f74be3f
Deletes code related to GME_Varmix
gustavo-marques Jun 6, 2019
94bc51b
Updating RGC codes
ElizabethYankovsky Jun 7, 2019
11834a8
Updating MOM6
ElizabethYankovsky Jun 7, 2019
25ea4dc
Changes in MEKE
gustavo-marques Jun 7, 2019
2d2f83f
Changes the way of counting the work
gustavo-marques Jun 7, 2019
5b81da9
(*) Vertical diagnostic remap symmetric bugfix
marshallward Jun 10, 2019
edb2b32
Vertical remap index syntax adjustment
marshallward Jun 10, 2019
a995acf
Reverts biharmonic constants to the origial definition
gustavo-marques Jun 10, 2019
22b6695
Remove trailing space
gustavo-marques Jun 11, 2019
91d0e26
Merge pull request #103 from gustavo-marques/gme_31May2019
alperaltuntas Jun 11, 2019
31dda12
Merge branch 'dev/master' into dev-master-candidate-2019-06-11
gustavo-marques Jun 11, 2019
418bece
Updating sponge and tracer
ElizabethYankovsky Jun 12, 2019
1864ae7
Correcting code comments
ElizabethYankovsky Jun 12, 2019
65b9401
Fixing formatting
ElizabethYankovsky Jun 12, 2019
688f75f
Merge pull request #933 from ElizabethYankovsky/myworkingbranch
Hallberg-NOAA Jun 13, 2019
e6033c0
(*) Bugfix: reproducing_sum, bin equals prec
marshallward Jun 15, 2019
f19a173
(*) Z-remap interface mask{Cu,Cv,B}i bugfix
marshallward Jun 17, 2019
1e30eb3
(*) Remapped d[uv]dt_dia, [uv]hml diagnostic fixes
marshallward Jun 14, 2019
a2a8f1a
Merge pull request #936 from marshallward/reprosum
adcroft Jun 17, 2019
d454213
Merge branch 'dev/gfdl' into new_diag_fix
marshallward Jun 17, 2019
4a2c212
(*) Horizontal remapping re-enabled, bugfixes
marshallward Jun 17, 2019
bf81b4a
Merge pull request #937 from marshallward/new_diag_fix
Hallberg-NOAA Jun 18, 2019
9d8468a
Commenting salt_flux adjustment in net_FW
gustavo-marques Jun 21, 2019
2ada29a
Adds MEKE_VISCOSITY_COEFF_AU and MEKE_VISCOSITY_COEFF_KU into the MEK…
gustavo-marques Jun 21, 2019
062e3b0
Obsolete parameter MEKE_VISCOSITY_COEFF
gustavo-marques Jun 21, 2019
afb07fb
Add MEKE_GEOMETRIC_EPSILON
gustavo-marques Jun 21, 2019
89168bf
move OMP calls below GME and above the K-loop
gustavo-marques Jun 21, 2019
98373e8
Fix hint syntax in MOM_obsolete_param
gustavo-marques Jun 21, 2019
97c2395
Commenting out salt_flux adjustment in net_FW in NUOPC cap
gustavo-marques Jun 23, 2019
3f7e9f6
changes needed for mom6 validation
Jun 24, 2019
fa22263
(+) Enable checksums for all diagnostics
marshallward Jun 25, 2019
e204ea7
Do not attach cell methods in diag chksum mode
marshallward Jun 26, 2019
2a9d421
Set default AH_VEL_SCALE back to zero
gustavo-marques Jun 26, 2019
058492a
Repro sum increment_ints_faster overflow check
marshallward Jun 27, 2019
1a71a55
Remove thickness_diffuse_CS from horizontal_viscosity
gustavo-marques Jun 27, 2019
0d1fbff
Issue FATAL error if SPLIT=False and USE_GME=True
gustavo-marques Jun 27, 2019
31dfefd
Removes Barotropic and thickness_diffuse from MOM_dynamics_unsplit*
gustavo-marques Jun 27, 2019
47886e3
Changes Barotropic to BT in horizontal_viscosity
gustavo-marques Jun 27, 2019
8f96916
Passes optional arg. (BT=CS%barotropic_CSp) in calls to horizontal_vi…
gustavo-marques Jun 27, 2019
1883c1c
Flux allocation check in diagnostics
marshallward Jun 27, 2019
91f3719
Disable diabatic KE flux for adiabatic runs
marshallward Jun 27, 2019
efe03c1
Conditional thermodynamic diags; Flux diag bugfix
marshallward Jun 27, 2019
3f8c425
Merge pull request #105 from NCAR/mvertens/mom6_validation
alperaltuntas Jun 27, 2019
db47de7
Merge pull request #940 from marshallward/repro_overflow
adcroft Jun 28, 2019
5c42192
Removes trailing space
gustavo-marques Jun 28, 2019
c34a767
Merge pull request #939 from marshallward/chksum_diag
Hallberg-NOAA Jun 28, 2019
7710506
Conditionally enable MEKE Kh diagnostics
marshallward Jul 2, 2019
f8758ec
Merge pull request #106 from gustavo-marques/bobs_solution
gustavo-marques Jul 3, 2019
b8e7050
Merge pull request #942 from marshallward/meke_kh_diag
adcroft Jul 3, 2019
7698afb
Merge branch 'gustavo-marques-dev-master-candidate-2019-06-11' into d…
adcroft Jul 5, 2019
cac0656
fixes to get taux and tauy roundoff between mct and nuopc
Jul 5, 2019
27485ef
Merge branch 'dev/master' into dev/gfdl
adcroft Jul 5, 2019
2faafaa
Fix for static compiles
adcroft Jul 5, 2019
573d3ff
Correct declaration of h in calc_QG_Leith_viscosity()
adcroft Jul 5, 2019
67dadc5
Merge pull request #943 from adcroft/static--mode-fixes-for-pr-935
Hallberg-NOAA Jul 5, 2019
71693b5
Split long comments in RGC_tracer.F90
Hallberg-NOAA Jul 8, 2019
7a9cf32
Split excessively long lines in 2 files
Hallberg-NOAA Jul 8, 2019
00d99ea
(*)Multiply fmax by US%s_to_T in MOM_hor_visc.F90
Hallberg-NOAA Jul 8, 2019
85939c3
Travis tests for lines exceeding 120 characters
Hallberg-NOAA Jul 8, 2019
4cb18ac
Merge pull request #944 from Hallberg-NOAA/fix_line_lengths
adcroft Jul 8, 2019
6ec503f
Merge branch 'dev/ncar' into mvertens/validation_fixes
Jul 9, 2019
87e6f17
removed trailing whitespace
Jul 9, 2019
3fcd942
Deletes comments
gustavo-marques Jul 10, 2019
05709a1
Merge pull request #104 from gustavo-marques/remove_salt_flux_from_ne…
gustavo-marques Jul 10, 2019
2a65e65
Merge pull request #107 from NCAR/mvertens/validation_fixes
gustavo-marques Jul 11, 2019
96214de
Merge branch 'dev-master-candidate-2019-07-08' into dev/master
adcroft Jul 11, 2019
f5899da
Merge branch 'dev/master' into merge-dev-master-candidate-2019-07-08
gustavo-marques Jul 11, 2019
b9844d7
Merge pull request #108 from gustavo-marques/merge-dev-master-candida…
gustavo-marques Jul 11, 2019
8da9eb9
changes to the interfaces to bring them more in line with dev/ncar la…
Jul 14, 2019
3995037
more updates to have caps consistent with dev/ncar
Jul 14, 2019
c4e349d
Merge branch 'dev/ncar' into mvertens/validation_fixes2
Jul 14, 2019
7c90fa0
changes to get MOM_ocean_model.F90 closer to nuopc_driver
Jul 16, 2019
3135f62
removed trailing whitespace
Jul 16, 2019
f72454b
changes to have minimal differences between nuopc and mct
Jul 17, 2019
562297c
more changes to have minimal differences between nuopc and mct
Jul 17, 2019
06a7c46
Merge pull request #112 from gustavo-marques/mct_nuopc_validation
gustavo-marques Jul 25, 2019
1305e73
Rename modules in MCT
gustavo-marques Jul 29, 2019
3b2ad3f
Rename modules in NUOPC
gustavo-marques Jul 29, 2019
8a04b99
Rename modules for MCT
gustavo-marques Jul 30, 2019
fc55c36
Rename modules for NUOPC
gustavo-marques Jul 30, 2019
a34bdf4
Capitalize MOM inside MCT modules
gustavo-marques Jul 30, 2019
d292a57
Deletes contribution from kv%slow when computing a_cpl
gustavo-marques Jul 30, 2019
21fd427
Make sure that MEKE%GME_snk is only used when the array is allocated
gustavo-marques Jul 30, 2019
c56450a
Deletes all code related to Jansen15_drag
gustavo-marques Jul 30, 2019
68ec55e
Merge pull request #113 from gustavo-marques/rename_modules
alperaltuntas Jul 31, 2019
815db63
Change default way to computing FrictWork in MEKE
gustavo-marques Aug 1, 2019
c149c20
Merge pull request #114 from gustavo-marques/update_mom_vert_friction
alperaltuntas Aug 1, 2019
35b5c76
Merge pull request #115 from gustavo-marques/update_meke
alperaltuntas Aug 2, 2019
1328636
Merge branch 'gustavo-marques-dev-master-candidate-ncar-2019-08-05' i…
adcroft Aug 16, 2019
887666b
Merge branch 'dev/master' into dev/master-ecbuild-sync
travissluka Aug 19, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view

Large diffs are not rendered by default.

Large diffs are not rendered by default.

25 changes: 10 additions & 15 deletions config_src/mct_driver/ocn_cap_methods.F90
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
module ocn_cap_methods

use ESMF, only: ESMF_clock, ESMF_time, ESMF_ClockGet, ESMF_TimeGet
use MOM_ocean_model, only: ocean_public_type, ocean_state_type
use MOM_surface_forcing, only: ice_ocean_boundary_type
use MOM_grid, only: ocean_grid_type
use MOM_domains, only: pass_var
use MOM_error_handler, only: is_root_pe
use mpp_domains_mod, only: mpp_get_compute_domain
use ocn_cpl_indices, only: cpl_indices_type
use ESMF, only: ESMF_clock, ESMF_time, ESMF_ClockGet, ESMF_TimeGet
use MOM_ocean_model_mct, only: ocean_public_type, ocean_state_type
use MOM_surface_forcing_mct, only: ice_ocean_boundary_type
use MOM_grid, only: ocean_grid_type
use MOM_domains, only: pass_var
use MOM_error_handler, only: is_root_pe
use mpp_domains_mod, only: mpp_get_compute_domain
use ocn_cpl_indices, only: cpl_indices_type

implicit none
private
Expand Down Expand Up @@ -71,9 +71,6 @@ subroutine ocn_import(x2o, ind, grid, ice_ocean_boundary, ocean_public, logunit,
! sensible heat flux (W/m2)
ice_ocean_boundary%t_flux(i,j) = x2o(ind%x2o_Foxx_sen,k)

! latent heat flux (W/m^2)
ice_ocean_boundary%latent_flux(i,j) = x2o(ind%x2o_Foxx_lat,k)

! snow&ice melt heat flux (W/m^2)
ice_ocean_boundary%seaice_melt_heat(i,j) = x2o(ind%x2o_Fioi_melth,k)

Expand All @@ -89,8 +86,8 @@ subroutine ocn_import(x2o, ind, grid, ice_ocean_boundary, ocean_public, logunit,
! surface pressure
ice_ocean_boundary%p(i,j) = x2o(ind%x2o_Sa_pslv,k) * GRID%mask2dT(i,j)

! salt flux (minus sign needed here -GMM)
ice_ocean_boundary%salt_flux(i,j) = -x2o(ind%x2o_Fioi_salt,k) * GRID%mask2dT(i,j)
! salt flux
ice_ocean_boundary%salt_flux(i,j) = x2o(ind%x2o_Fioi_salt,k) * GRID%mask2dT(i,j)

! 1) visible, direct shortwave (W/m2)
! 2) visible, diffuse shortwave (W/m2)
Expand Down Expand Up @@ -127,8 +124,6 @@ subroutine ocn_import(x2o, ind, grid, ice_ocean_boundary, ocean_public, logunit,
day,secs,j,i,ice_ocean_boundary%seaice_melt_heat(i,j)
write(logunit,F01)'import: day, secs, j, i, seaice_melt = ',&
day,secs,j,i,ice_ocean_boundary%seaice_melt(i,j)
write(logunit,F01)'import: day, secs, j, i, latent_flux = ',&
day,secs,j,i,ice_ocean_boundary%latent_flux(i,j)
write(logunit,F01)'import: day, secs, j, i, runoff = ',&
day,secs,j,i,ice_ocean_boundary%rofl_flux(i,j) + ice_ocean_boundary%rofi_flux(i,j)
write(logunit,F01)'import: day, secs, j, i, psurf = ',&
Expand Down
67 changes: 61 additions & 6 deletions config_src/mct_driver/ocn_comp_mct.F90
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@ module ocn_comp_mct
shr_file_getLogUnit, shr_file_getLogLevel, &
shr_file_setLogUnit, shr_file_setLogLevel

use MOM_surface_forcing, only: IOB_allocate, ice_ocean_boundary_type

! MOM6 modules
use MOM, only: extract_surface_state
use MOM_variables, only: surface
Expand All @@ -46,10 +44,10 @@ module ocn_comp_mct
use mpp_domains_mod, only: mpp_get_compute_domain

! Previously inlined - now in separate modules
use MOM_ocean_model, only: ocean_public_type, ocean_state_type
use MOM_ocean_model, only: ocean_model_init , update_ocean_model, ocean_model_end
use MOM_ocean_model, only: convert_state_to_ocean_type
use MOM_surface_forcing, only: surface_forcing_CS, forcing_save_restart
use MOM_ocean_model_mct, only: ocean_public_type, ocean_state_type
use MOM_ocean_model_mct, only: ocean_model_init , update_ocean_model, ocean_model_end
use MOM_ocean_model_mct, only: convert_state_to_ocean_type
use MOM_surface_forcing_mct, only: surface_forcing_CS, forcing_save_restart, ice_ocean_boundary_type
use ocn_cap_methods, only: ocn_import, ocn_export

! FMS modules
Expand Down Expand Up @@ -813,4 +811,61 @@ end subroutine ocean_model_init_sfc
!! CO2
!! DMS

!> Allocates ice-ocean boundary type containers and sets to 0.
subroutine IOB_allocate(IOB, isc, iec, jsc, jec)
type(ice_ocean_boundary_type), intent(inout) :: IOB !< An ice-ocean boundary type with fluxes to drive
integer, intent(in) :: isc, iec, jsc, jec !< The ocean's local grid size

allocate ( IOB% rofl_flux (isc:iec,jsc:jec), &
IOB% rofi_flux (isc:iec,jsc:jec), &
IOB% u_flux (isc:iec,jsc:jec), &
IOB% v_flux (isc:iec,jsc:jec), &
IOB% t_flux (isc:iec,jsc:jec), &
IOB% seaice_melt_heat (isc:iec,jsc:jec),&
IOB% seaice_melt (isc:iec,jsc:jec), &
IOB% q_flux (isc:iec,jsc:jec), &
IOB% salt_flux (isc:iec,jsc:jec), &
IOB% lw_flux (isc:iec,jsc:jec), &
IOB% sw_flux_vis_dir (isc:iec,jsc:jec), &
IOB% sw_flux_vis_dif (isc:iec,jsc:jec), &
IOB% sw_flux_nir_dir (isc:iec,jsc:jec), &
IOB% sw_flux_nir_dif (isc:iec,jsc:jec), &
IOB% lprec (isc:iec,jsc:jec), &
IOB% fprec (isc:iec,jsc:jec), &
IOB% ustar_berg (isc:iec,jsc:jec), &
IOB% area_berg (isc:iec,jsc:jec), &
IOB% mass_berg (isc:iec,jsc:jec), &
IOB% calving (isc:iec,jsc:jec), &
IOB% runoff_hflx (isc:iec,jsc:jec), &
IOB% calving_hflx (isc:iec,jsc:jec), &
IOB% mi (isc:iec,jsc:jec), &
IOB% p (isc:iec,jsc:jec))

IOB%rofl_flux = 0.0
IOB%rofi_flux = 0.0
IOB%u_flux = 0.0
IOB%v_flux = 0.0
IOB%t_flux = 0.0
IOB%seaice_melt_heat = 0.0
IOB%seaice_melt = 0.0
IOB%q_flux = 0.0
IOB%salt_flux = 0.0
IOB%lw_flux = 0.0
IOB%sw_flux_vis_dir = 0.0
IOB%sw_flux_vis_dif = 0.0
IOB%sw_flux_nir_dir = 0.0
IOB%sw_flux_nir_dif = 0.0
IOB%lprec = 0.0
IOB%fprec = 0.0
IOB%ustar_berg = 0.0
IOB%area_berg = 0.0
IOB%mass_berg = 0.0
IOB%calving = 0.0
IOB%runoff_hflx = 0.0
IOB%calving_hflx = 0.0
IOB%mi = 0.0
IOB%p = 0.0

end subroutine IOB_allocate

end module ocn_comp_mct
Loading