Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update met to 11.1.0 once released and adjust date range for patch #646

Closed
climbfuji opened this issue Jun 23, 2023 · 3 comments · Fixed by #722
Closed

Update met to 11.1.0 once released and adjust date range for patch #646

climbfuji opened this issue Jun 23, 2023 · 3 comments · Fixed by #722
Assignees
Labels
bug Something is not working INFRA JEDI Infrastructure

Comments

@climbfuji
Copy link
Collaborator

climbfuji commented Jun 23, 2023

Describe the bug
This is just a reminder that until met@11.0.3 is released, we can't build met@11 (and therefore metplus@5 and global-workflow-env) on macOS. I previously thought this was only the case for the M1 (aarch64) architecture, but it is the same on Intel (x86-64).

UPDATE - see #646 (comment)

To Reproduce
Try it.

Expected behavior
The error is expected. This issue will be closed by a PR that adds met@11.0.3, once released.

System:
macOS (version and architecture don't matter)

Additional context
n/a

@climbfuji climbfuji added the bug Something is not working label Jun 23, 2023
@climbfuji climbfuji self-assigned this Jun 23, 2023
@climbfuji climbfuji added the INFRA JEDI Infrastructure label Jun 28, 2023
@climbfuji
Copy link
Collaborator Author

This is actually on a problem on release-1.4.x, because develop has a patch:

https://github.com/JCSDA/spack/blob/01d6aa5239a8f46862d0f35a9f3533afdb9151a2/var/spack/repos/builtin/packages/met/package.py#L63

When met@11.1.3 or whatever the tag is comes out, then this patch will no longer be needed and likely fail. We should then update the when statement accordingly - keeping this issue open until that is done.

@climbfuji climbfuji changed the title unified-dev environment does not build completely on macOS (met@11.0.2 error) Update met to 11.0.3 once released and adjust date range for patch Jul 19, 2023
@srherbener srherbener changed the title Update met to 11.0.3 once released and adjust date range for patch Update met to 11.1.0 once released and adjust date range for patch Jul 27, 2023
@srherbener
Copy link
Collaborator

The expected release date for met@11.1.0 which will contain the fixes we need to remove the patches is targeted for July 31, 2023.

@climbfuji
Copy link
Collaborator Author

It's been released, I will work on the update next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working INFRA JEDI Infrastructure
Projects
No open projects
2 participants