-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Ubuntu CI runner from old AWS c6i ParallelCluster to c6a single-node instance #1085
Update Ubuntu CI runner from old AWS c6i ParallelCluster to c6a single-node instance #1085
Conversation
…-ci-x86_64.yaml to ubuntu-ci-x86_64-intel.yaml, and update both workflows (incomplete)
…eature/ubuntu-ci-c6a_workflow
…eature/ubuntu-ci-c6a_workflow
…github/workflows/ubuntu-ci-x86_64-intel.yaml.tmp to debug GNU build
…d temporarily rename .github/workflows/macos-ci-aarch64.yaml
…tu-ci-x86_64-gnu.yaml
This is finally ready for review. I also ran the container CI test (needs to run from a branch in the spack-stack repo) and it was successful: https://github.com/JCSDA/spack-stack/actions/runs/8825426794 |
@@ -0,0 +1,192 @@ | |||
name: ubuntu-ci-c6a-x86_64-gnu-build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is almost a copy of the .github/workflows/ubuntu-ci-x86_64-intel.yaml
workflow. There are subtle differences and I thought it might be better to keep them apart, even though this means some amount of code duplication. We could move some of the steps into a common/shared workflow file and draw from there in the future ...
run: | | ||
# Get day of week to decide whether to use build caches or not |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I adopted this logic from the previously removed workflow on the AWS ParallelCluster (R&D cluster)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I contributed many of the changes in this PR, therefore I should not be approving it. But I am obviously happy with it :-)
@ashley314 Can you please do a self-review of this PR, especially all the changes I added on top of yours (apologies for the many updates)? Thanks! |
Will do! @climbfuji thanks for all of the updates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not able to approve this PR, but I reviewed and everything looks good. Thank you for getting these working!
@AlexanderRichert-NOAA Do you have time for a review of this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do the file names not contain the "c6a" marking, but the internal names in the configuration do contain "c6a"? Just want to check if this was what was intended. Thanks!
Only the name of the runner differs, which is totally independent of the yaml. |
…eature/ubuntu-ci-c6a_workflow
Sounds good. I just wanted to double check. |
Summary
v1.3.0
of the CMakeModules submodule - no code changes here, we tagged the commit that spack-stack was pointing to for several releases asv1.3.0
.spack
for a few accumulated changes, including Add -fPIC to hdf-eos2 builds spack#426 which is required for this PR.Testing
Systems affected
CI testing
Issue(s) addressed
Working towards https://github.com/JCSDA-internal/CI/issues/118
Dependencies
Checklist