Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release/1.5.0: site config and doc updates round 2 (S4, aws-pcluster, Discover, Nautilus, JCSDA CI containers) #775

Merged
merged 22 commits into from
Sep 14, 2023
Merged

release/1.5.0: site config and doc updates round 2 (S4, aws-pcluster, Discover, Nautilus, JCSDA CI containers) #775

merged 22 commits into from
Sep 14, 2023

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Sep 13, 2023 •
edited
Loading

Summary

Round 2 of the site config and documentation updates for release 1.5.0: S4, AWS Parallelcluster, Discover, Nautilus, JCSDA CI containers.

Testing

spack-stack-1.5.0 installed on all platforms and basic tests run as described in #765

Applications affected

All applications using spack-stack-1.5.0 on these platforms

Systems affected

See above

Dependencies

n/a

Issue(s) addressed

Working towards #765

Checklist

  • This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.

@climbfuji climbfuji self-assigned this Sep 13, 2023
@climbfuji climbfuji added the INFRA JEDI Infrastructure label Sep 13, 2023
climbfuji
climbfuji commented Sep 13, 2023
View reviewed changes
configs/sites/discover/packages.yaml
@@ -3,7 +3,6 @@ packages:
compiler:: [intel@2022.0.1, gcc@10.1.0]
providers:
mpi:: [intel-oneapi-mpi@2021.5.0, openmpi@4.1.3]
target: [ivybridge]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer needed, all nodes on Discover are now skylake/cascadelake

@climbfuji climbfuji force-pushed the feature/rel_150_site_updates_round2 branch from 92ba855 to 1deeff4 Compare September 13, 2023 20:56
@climbfuji climbfuji mentioned this pull request Sep 14, 2023
Closed
climbfuji
climbfuji commented Sep 14, 2023
View reviewed changes
configs/containers/docker-ubuntu-clang-mpich.yaml
@@ -235,8 +235,6 @@ spack:
echo "export CXX=clang++" >> /root/.bashrc && \
echo "export FC=gfortran" >> /root/.bashrc && \
printf "[credential]\n helper = cache --timeout=7200\n" >> /root/.gitconfig
# Source spack environment script for root
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to an upstream change in spack, these scripts are no longer needed/no longer exist.

climbfuji
climbfuji commented Sep 14, 2023
View reviewed changes
configs/sites/aws-pcluster/modules.yaml
@@ -4,7 +4,6 @@ modules:
- lmod
lmod:
include:
# List of packages for which we need modules that are blacklisted by default
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DEI DEI

@climbfuji climbfuji marked this pull request as ready for review September 14, 2023 17:33
@climbfuji climbfuji changed the title WIP - release/1.5.0: site config and doc updates round 2 (S4, aws-pcluster, Discover, Nautilus, JCSDA CI containers) release/1.5.0: site config and doc updates round 2 (S4, aws-pcluster, Discover, Nautilus, JCSDA CI containers) Sep 14, 2023
@AlexanderRichert-NOAA
Copy link
Collaborator

@climbfuji could I trouble you to whitelist the python module for acorn while we're at it? :)

    lmod:
      include:
      - python

in configs/sites/acorn/modules.yaml. Already tested in the installation.

@climbfuji
Copy link
Collaborator Author

@climbfuji could I trouble you to whitelist the python module for acorn while we're at it? :)

    lmod:
      include:
      - python

in configs/sites/acorn/modules.yaml. Already tested in the installation.

Of course, I will include it in the module file.

@climbfuji
Copy link
Collaborator Author

@climbfuji could I trouble you to whitelist the python module for acorn while we're at it? :)

    lmod:
      include:
      - python

in configs/sites/acorn/modules.yaml. Already tested in the installation.

Of course, I will include it in the module file.

Done!

@climbfuji climbfuji enabled auto-merge (squash) September 14, 2023 18:37
@climbfuji climbfuji merged commit 5d76fdd into JCSDA:release/1.5.0 Sep 14, 2023
@climbfuji climbfuji deleted the feature/rel_150_site_updates_round2 branch September 14, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderRichert-NOAA AlexanderRichert-NOAA AlexanderRichert-NOAA approved these changes

@srherbener srherbener Awaiting requested review from srherbener

@sking112 sking112 Awaiting requested review from sking112

@ulmononian ulmononian Awaiting requested review from ulmononian

@Hang-Lei-NOAA Hang-Lei-NOAA Awaiting requested review from Hang-Lei-NOAA

Assignees

@climbfuji climbfuji

Labels
INFRA JEDI Infrastructure
Projects
No open projects
spack-stack-1.5.0 (2023 Q3)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@climbfuji @AlexanderRichert-NOAA