-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update spack stack create ctr
: make specs configurable, remove warnings, add CI builds
#805
Merged
climbfuji
merged 14 commits into
JCSDA:develop
from
climbfuji:feature/container_env_updates
Oct 4, 2023
Merged
Update spack stack create ctr
: make specs configurable, remove warnings, add CI builds
#805
climbfuji
merged 14 commits into
JCSDA:develop
from
climbfuji:feature/container_env_updates
Oct 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ry with different sets of specs, updated README.md
3 tasks
climbfuji
added
INFRA
JEDI Infrastructure
container-ci
Trigger CI tests for container builds
labels
Oct 3, 2023
climbfuji
added
container-ci
Trigger CI tests for container builds
and removed
container-ci
Trigger CI tests for container builds
labels
Oct 3, 2023
climbfuji
force-pushed
the
feature/container_env_updates
branch
from
October 3, 2023 17:54
4a82a36
to
23d1afa
Compare
climbfuji
added
container-ci
Trigger CI tests for container builds
and removed
container-ci
Trigger CI tests for container builds
labels
Oct 3, 2023
climbfuji
force-pushed
the
feature/container_env_updates
branch
from
October 3, 2023 17:56
23d1afa
to
fc200ae
Compare
climbfuji
added
container-ci
Trigger CI tests for container builds
and removed
container-ci
Trigger CI tests for container builds
labels
Oct 3, 2023
climbfuji
force-pushed
the
feature/container_env_updates
branch
from
October 3, 2023 18:08
fc200ae
to
e8136f9
Compare
climbfuji
added
container-ci
Trigger CI tests for container builds
and removed
container-ci
Trigger CI tests for container builds
labels
Oct 3, 2023
climbfuji
commented
Oct 3, 2023
@@ -110,7 +109,7 @@ spack: | |||
os: ubuntu:20.04 | |||
spack: | |||
url: https://github.com/jcsda/spack | |||
ref: spack-stack-1.5.0 | |||
ref: jcsda_emc_spack_stack |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An actual bug fix, this should not have been updated when spack-stack-1.5.0
was merged into develop.
climbfuji
added
container-ci
Trigger CI tests for container builds
and removed
container-ci
Trigger CI tests for container builds
labels
Oct 3, 2023
…eature/container_env_updates
climbfuji
requested review from
AlexanderRichert-NOAA,
srherbener,
ulmononian and
natalie-perlin
October 4, 2023 01:45
climbfuji
added
container-ci
Trigger CI tests for container builds
and removed
container-ci
Trigger CI tests for container builds
labels
Oct 4, 2023
ulmononian
approved these changes
Oct 4, 2023
srherbener
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes for how we create containers, and CI testing for them.
spack stack create ctr
command is updated, it takes four options (--container
,--specs
, optional--dir
, optional--overwrite
). This way, we don't need to manually add specs to the container recipes files, and we also get rid of annoying warnings from invalid options in the containerspack.yaml
.workflow_dispatch
(can choose spec, container). Because of the no-choice limitation for containers/specs for PR builds, I am not sure how valuable those are. Maybeworkflow_dispatch
is good enough? Keep it simple.Testing
docker-ubuntu-gnu-openmpi
withjedi-ci
)Applications affected
JEDI CI container builds
Systems affected
None
Dependencies
Issue(s) addressed
Resolves #146
Checklist