Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable numpy AVX512 when compiled with Intel classic #486

Closed
wants to merge 13 commits into from
Closed

Disable numpy AVX512 when compiled with Intel classic #486

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
26dd56f
Disable numpy AVX512 when compiled with Intel classic
DavidHuber-NOAA Nov 26, 2024
e3fdef4
Add numpy and matplotlib issues for reference
DavidHuber-NOAA Nov 26, 2024
2259a39
Try setting cpu-dispatch flags
DavidHuber-NOAA Nov 26, 2024
a3c2544
Add patch to handle volatile Intel AVX512 conversions
DavidHuber-NOAA Nov 27, 2024
bbf38f2
Disable Intel Classic AVX512_SPR instructions
DavidHuber-NOAA Nov 27, 2024
2a1d46a
Merge remote-tracking branch 'origin/spack-stack-dev' into fix/numpy_…
DavidHuber-NOAA Nov 27, 2024
3b7c774
Run black on package.py
DavidHuber-NOAA Nov 27, 2024
ce9b4f0
Remove unneeded check_archs
DavidHuber-NOAA Nov 27, 2024
e8fc932
Add when specifier for config_settings
DavidHuber-NOAA Nov 27, 2024
3a37c74
Remove remaining block of check_archs
DavidHuber-NOAA Nov 27, 2024
9789f54
Clean up Intel patch
DavidHuber-NOAA Nov 27, 2024
34b2abc
Remove unneeded whitespace.
DavidHuber-NOAA Dec 5, 2024
74796a3
Merge branch 'spack-stack-dev' into fix/numpy_avx512
DavidHuber-NOAA Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions var/spack/repos/builtin/packages/py-numpy/package.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,6 +482,11 @@ def setup_build_environment(self, env):

env.set("NPY_LAPACK_ORDER", lapack)

def setup_run_environment(self, env):
archs = ("x86_64_v4:", "cannonlake:", "mic_knl")
climbfuji marked this conversation as resolved.
Show resolved Hide resolved
if any([self.spec.satisfies(f"target={arch} %intel") for arch in archs]):
env.set("NPY_DISABLE_CPU_FEATURES", "AVX512F")

@run_after("install")
@on_package_attributes(run_tests=True)
def install_test(self):
Expand Down
Loading