Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configurable parent mailer #53

Closed
wants to merge 3 commits into from
Closed

configurable parent mailer #53

wants to merge 3 commits into from

Conversation

mespina
Copy link

@mespina mespina commented Apr 30, 2015

Parent Mailer for customizations

@@ -1,4 +1,4 @@
class ContactUs::ContactMailer < ActionMailer::Base
class ContactUs::ContactMailer < ContactUs.parent_mailer ? ContactUs.parent_mailer.constantize : ActionMailer::Base
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long. [115/80]

@@ -19,6 +19,10 @@ module ContactUs
# URL after a successful submission
mattr_accessor :success_redirect

# Configure parent mailer
mattr_accessor :parent_mailer
@@parent_mailer = 'ActionMailer::Base'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

@mespina mespina force-pushed the master branch 2 times, most recently from b81bd24 to b8821d9 Compare April 30, 2015 14:34
@JDutil
Copy link
Owner

JDutil commented Apr 30, 2015

Could you please delete and gitignore the .DS_Store file.

@JDutil JDutil closed this in e332975 May 1, 2015
@JDutil
Copy link
Owner

JDutil commented May 1, 2015

Thanks

@JDutil
Copy link
Owner

JDutil commented May 1, 2015

Released v1.1.0 with your change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants