-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #138 #139
Issue #138 #139
Conversation
IO.console.winsize returns [ rows, columns ], but terminal_size should return [ columns, rows ]
Thanks for the quick fix! Sorry, I somehow can't install the version from the
The same in $ irb
> require 'highline'
LoadError: cannot load such file -- highline
from /Users/felixkrause/.rvm/rubies/ruby-2.0.0-p481/lib/ruby/site_ruby/2.0.0/rubygems/core_ext/kernel_require.rb:55:in `require' If I do a |
Hi @KrauseFx , Try Perhaps the use of sudo here could try to install the gem into a multi user rvm install (at /usr/local/rvm, not at ~/.rvm). Not sure. (https://rvm.io/rvm/install) Any way, I have managed to test it over here with...
... against the 2 versions. I think is safe for @JEG2 to merge now. And thanks for reporting the issue. |
I'll make a release if @KrauseFx reports this is working… |
I just released the fix. |
Thank you @JEG2, really appreciated 👍 |
=== 4.3.4 / 2015-05-03 * Fixed a regression with the compact help formatter. === 4.3.3 / 2015-04-21 * Updated to highline 1.7.2 to fix a regression with terminal size (JEG2/highline#139). * Help formatting updated to look better for commands with long names. (@jszwedko) === 4.3.2 / 2015-03-31 * Version bump to publish new location of Commander to Rubygems. Moved to https://github.com/commander-rb/commander === 4.3.1 / 2015-03-27 * Fix various Ruby warnings for circular requires, etc. * Update to use highline 1.7 (@SkyTrix)
Related to #138
As a fast fix I just reapplied the commit and bumped up the version.
@KrauseFx, could you check if this fix for you before @JEG2 makes a new release?
(I'm not able to reproduce neither the fail nor the fix by now).