Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent text colours in menu items when using Arc themes #259

Closed
grimlock81 opened this issue Feb 16, 2021 · 1 comment
Closed

Inconsistent text colours in menu items when using Arc themes #259

grimlock81 opened this issue Feb 16, 2021 · 1 comment
Milestone

Comments

@grimlock81
Copy link

grimlock81 commented Feb 16, 2021

Firstly @DevCharly congrats on the 1.0 release, that's an amazing milestone for such a great project. Consider this the first issue for 1.0 😄

When using these themes:

  • Arc
  • Arc - Orange

The text colour of a JMenu or JMenuItem is lighter than the text colour of a JRadioButtonMenuItem or a JCheckBoxMenuItem. This is clearest when opening menus in the FlatLaf Demo frame. This gives users a false impression that those items are disabled. This problem also occurs when used in a JPopupMenu.

Arc

Arc Orange

For the equivalent Dark themes:

  • Arc Dark (only the com.formdev.flatlaf.intellijthemes.FlatArcDarkIJTheme version, the com.formdev.flatlaf.intellijthemes.materialthemeuilite.FlatArcDarkIJTheme version is okay
  • Arc Dark - Orange

the problem is reversed although the difference is not as obvious as the light themes. If you look closely the JRadioButtonMenuItem and JCheckBoxMenuItem text is slightly lighter than the JMenu/JMenuItem.

Arc Dark Arc Dark - Orange

I have gone through all the other themes, they are not affected by this issue.

DevCharly added a commit that referenced this issue Feb 19, 2021
@DevCharly DevCharly added this to the 1.1 milestone Feb 19, 2021
@DevCharly
Copy link
Collaborator

Thx. 😃
Now fixed in main branch.

The author of the Arc themes simply forgot to set colors for checkbox and radiobutton menuitems because IntelliJ IDEA seems not use them...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants