-
-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent text colours in menu items when using Arc themes #259
Milestone
Comments
DevCharly
added a commit
that referenced
this issue
Feb 19, 2021
…MenuItem in all "Arc" themes (issue #259)
Thx. 😃 The author of the Arc themes simply forgot to set colors for checkbox and radiobutton menuitems because IntelliJ IDEA seems not use them... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Firstly @DevCharly congrats on the 1.0 release, that's an amazing milestone for such a great project. Consider this the first issue for 1.0 😄
When using these themes:
The text colour of a JMenu or JMenuItem is lighter than the text colour of a JRadioButtonMenuItem or a JCheckBoxMenuItem. This is clearest when opening menus in the FlatLaf Demo frame. This gives users a false impression that those items are disabled. This problem also occurs when used in a JPopupMenu.
For the equivalent Dark themes:
com.formdev.flatlaf.intellijthemes.FlatArcDarkIJTheme
version, thecom.formdev.flatlaf.intellijthemes.materialthemeuilite.FlatArcDarkIJTheme
version is okaythe problem is reversed although the difference is not as obvious as the light themes. If you look closely the JRadioButtonMenuItem and JCheckBoxMenuItem text is slightly lighter than the JMenu/JMenuItem.
I have gone through all the other themes, they are not affected by this issue.
The text was updated successfully, but these errors were encountered: