Support for Windows on ARM 64-bit #443

xanderberkhout · 2021-12-14T17:29:11Z

I just tested a Java Swing application with the FlatLaf on Windows 11 ARM 64-bit and I got the following error:

java.lang.UnsatisfiedLinkError: C:\Users\xander\AppData\Local\Temp\flatlaf.temp\flatlaf-windows-x86-20900948333330.dll: Can't load IA 32-bit .dll on a ARM 64-bit platform
        at java.base/jdk.internal.loader.NativeLibraries.load(Native Method)
        at java.base/jdk.internal.loader.NativeLibraries$NativeLibraryImpl.open(NativeLibraries.java:384)
        at java.base/jdk.internal.loader.NativeLibraries.loadLibrary(NativeLibraries.java:228)
        at java.base/jdk.internal.loader.NativeLibraries.loadLibrary(NativeLibraries.java:170)
        at java.base/java.lang.ClassLoader.loadLibrary(ClassLoader.java:2389)
        at java.base/java.lang.Runtime.load0(Runtime.java:755)
        at java.base/java.lang.System.load(System.java:1953)
        at com.formdev.flatlaf.util.NativeLibrary.loadLibraryFromJar(NativeLibrary.java:108)
        at com.formdev.flatlaf.util.NativeLibrary.<init>(NativeLibrary.java:59)
        at com.formdev.flatlaf.ui.FlatWindowsNativeWindowBorder.getInstance(FlatWindowsNativeWindowBorder.java:113)
        at com.formdev.flatlaf.ui.FlatNativeWindowBorder.initialize(FlatNativeWindowBorder.java:274)
        at com.formdev.flatlaf.ui.FlatNativeWindowBorder.isSupported(FlatNativeWindowBorder.java:68)
        at com.formdev.flatlaf.ui.FlatNativeWindowBorder.install(FlatNativeWindowBorder.java:76)
        at com.formdev.flatlaf.ui.FlatRootPaneUI.installNativeWindowBorder(FlatRootPaneUI.java:205)
        at com.formdev.flatlaf.ui.FlatRootPaneUI.installUI(FlatRootPaneUI.java:105)
        at java.desktop/javax.swing.JComponent.setUI(JComponent.java:730)
        at java.desktop/javax.swing.JRootPane.setUI(JRootPane.java:445)
        at java.desktop/javax.swing.JRootPane.updateUI(JRootPane.java:455)
        at java.desktop/javax.swing.JRootPane.<init>(JRootPane.java:349)
        at java.desktop/javax.swing.JWindow.createRootPane(JWindow.java:274)
        at java.desktop/javax.swing.JWindow.windowInit(JWindow.java:262)
        at java.desktop/javax.swing.JWindow.<init>(JWindow.java:189)

So the question is can I ignore this? There seems to be no DLL available for this platform. Is this planned?

The text was updated successfully, but these errors were encountered:

DevCharly · 2021-12-14T18:44:34Z

Thanks for reporting.

So the question is can I ignore this?

Don't think so. Or does the application work?

Please disable the Flatlaf window decorations (that uses the DLL), via command line option: (see FlatLaf System Properties)

-Dflatlaf.useWindowDecorations=false

Then it should work without exception.

There seems to be no DLL available for this platform. Is this planned?

Not at the moment. Simply because I don't have a machine to build and test it.
Also don't know whether GitHub Actions, which are used to build release DLLs, support Windows ARM.
Maybe it is possible to build a ARM DLL on a x86 machine? Thanks.

Anyway I'm very interested in at least avoiding this exception, but I don't know how to detect whether running on ARM CPU.
Could you please run following program, which dumps Java's system properties, and post the output here?

import java.util.Properties;

public class DumpSystemProperties
{
    public static void main( String[] args ) {
        Properties properties = System.getProperties();
        properties.keySet().stream().sorted().forEach( key -> {
            System.out.println( key + " = '" + properties.getProperty( (String) key ) + "'" );
        });
    }
}

xanderberkhout · 2021-12-14T19:32:22Z

The application works as I don't know what the Window decoration does exactly.

os.arch=aarch64

This means you are running on ARM 64-bit.

I think now there is official support for Windows on ARM64 since Java 16/17 (I am using Bellsoft) I tried to run my application on a Mac with M1 processor running Windows 11 in a virtual machine in Parallels.

xanderberkhout · 2021-12-14T19:41:27Z

Here are the most interesting properties for Windows 11 on Arm 64-bit:

file.encoding=Cp1252
file.separator=\

os.version=10.0
os.name=Windows 10
os.arch=aarch64

java.version=17.0.1
java.vm.vendor=BellSoft
java.vm.name=OpenJDK 64-Bit Server VM
java.vm.specification.version=17
java.vm.specification.vendor=Oracle Corporation
java.vm.version=17.0.1+12-LTS

java.runtime.version=17.0.1+12-LTS
java.runtime.name=OpenJDK Runtime Environment
java.vendor=BellSoft

Using JShell:
System.getProperties().forEach((key, entry) -> System.out.println(key + "=" + entry));

… for ARM processors (issue #443)

DevCharly · 2021-12-15T00:13:29Z

Thanks for the info.

The application works as I don't know what the Window decoration does exactly.

This enables menu bar embedded into window title bar.
And also the full dark window title bar.

I tried to run my application on a Mac with M1 processor running Windows 11 in a virtual machine in Parallels.

Many thanks for this hint. Have an M1 Mac. 😄

A fix for the exception is in latest 2.0-SNAPSHOT build: https://github.com/JFormDesigner/FlatLaf#snapshots

Would be great if you could try it out.
Hope it works. Thanks.

xberkhout · 2021-12-15T19:39:38Z

I don't see an exception anymore, so that looks good.

I have now installed Eclipse on Windows 11 Arm64 so I can debug faster.

Do you intend to add a .dll in the native part for Windows the coming year? There are now only two for x86 and x86_64. Would be nice to support all ARM platforms.

xanderberkhout · 2021-12-22T19:05:29Z

It seems the original error is now solved with ARM64 bit Windows, but happens now on Windows x86, 32-bit on the 2.0rc1.

The program continues so it is not a big problem, but it is ugly.

DevCharly · 2021-12-23T12:47:43Z

..., but happens now on Windows x86, 32-bit on the 2.0rc1.

What exactly do you mean.
Is there now a UnsatisfiedLinkError on 32bit Windows?

What Java version / vendor do you use?

Just tried with a 32bit JRE (17.0.1 from adoption.net) on Windows 10 64bit and it works fine.

xanderberkhout · 2021-12-23T12:52:36Z

yes, there was an UnsatisfiedLinkError with Bellsoft 17.0.1 on Windows 10 32-bit

DevCharly · 2021-12-23T14:06:23Z

Tried Bellsoft 17.0.1 32bit JRE and it works fine (on Windows 10 64bit; don't have 32bit Windows anymore)

What it the value of system property os.arch?
And it works with FlatLaf 1.6.x?
Can you post the exception?

xanderberkhout · 2021-12-23T14:08:46Z

It was not my own computer, so I cannot check directly. So I will try to find a virtual machine with Windows 10 32-bit. It is not a showstopper as the program continues.

xanderberkhout · 2021-12-23T15:24:14Z

I have downloaded Windows 10 32-bit in Parallels and you are right. There is no issue with FlatLaf on Windows 32-bit in this virtual machine. I think there is an issue with the other computer and not with FlatLaf. So sorry to bother you.

syoon2 · 2023-08-04T10:41:49Z

I use a Windows on ARM machine (Surface Pro X, to be specific) and tried running a FlatLaf application on it. Didn't encounter any crash or error with the latest stable (v3.1.1), but embedded menu bar seems unavailable.

Also don't know whether GitHub Actions, which are used to build release DLLs, support Windows ARM.
Maybe it is possible to build a ARM DLL on a x86 machine? Thanks.

#443 (comment)

AFAIK GitHub Actions do not offer a Windows on ARM VM. Fortunately Visual C++ provides cross compiling and an ARM DLL can be built on a x86 machine (see #707 for PoC).

I managed to compile and build FlatLaf with an ARM DLL, but even in this version, the embedded menu bar does not work right away (try building & running flatlaf-demo if you need a repro) - not quite sure what the cause of this would be though.

DevCharly · 2023-08-04T12:28:46Z

@syoon2 thanks for working on this issue 👍

You need to modify these lines:

FlatLaf/flatlaf-core/src/main/java/com/formdev/flatlaf/ui/FlatNativeLibrary.java

Line 58 in b47ed94

    
           if( SystemInfo.isWindows_10_orLater && (SystemInfo.isX86 || SystemInfo.isX86_64) ) {

and

FlatLaf/flatlaf-core/src/main/java/com/formdev/flatlaf/ui/FlatNativeLibrary.java

Line 61 in b47ed94

classifier = SystemInfo.isX86_64 ? "windows-x86_64" : "windows-x86";

and

FlatLaf/flatlaf-core/src/main/java/com/formdev/flatlaf/ui/FlatWindowsNativeWindowBorder.java

Line 92 in b47ed94

if( !SystemInfo.isX86 && !SystemInfo.isX86_64 )

BTW please do no commit the ARM DLL to git. I'll do this when merging. I need to digitally sign the DLL.

syoon2 · 2023-08-05T03:09:59Z

@DevCharly Yep, #707 is now updated with the edits to the lines you mentioned and ready for review :-)
I tried recompiling and building flatlaf-demo, and the embedded menu bar works flawlessly both on x86_64 and aarch64 🎉

, PR #707) built by GitHub Actions: https://github.com/JFormDesigner/FlatLaf/actions/runs/5771160235 locally signed Windows DLLs with FormDev Software GmbH code signing certificate

DevCharly · 2023-08-05T14:38:02Z

Merged in latest 3.2-SNAPSHOT: https://github.com/JFormDesigner/FlatLaf#snapshots

Could you please test this build and let me know whether it works? Thanks.

syoon2 · 2023-08-05T15:19:26Z

Just tested with my Surface Pro X - seems to work as expected :)

DevCharly added a commit that referenced this issue Dec 14, 2021

Native window decorations: fixed UnsatisfiedLinkError on Windows 11…

0bd1e41

… for ARM processors (issue #443)

syoon2 mentioned this issue Aug 4, 2023

Windows on ARM Support #707

Merged

DevCharly closed this as completed in #707 Aug 5, 2023

DevCharly added this to the 3.2 milestone Aug 5, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support for Windows on ARM 64-bit #443

Support for Windows on ARM 64-bit #443

xanderberkhout commented Dec 14, 2021

DevCharly commented Dec 14, 2021

xanderberkhout commented Dec 14, 2021 •

edited

Loading

xanderberkhout commented Dec 14, 2021 •

edited

Loading

DevCharly commented Dec 15, 2021

xberkhout commented Dec 15, 2021 •

edited

Loading

xanderberkhout commented Dec 22, 2021

DevCharly commented Dec 23, 2021

xanderberkhout commented Dec 23, 2021

DevCharly commented Dec 23, 2021

xanderberkhout commented Dec 23, 2021 •

edited

Loading

xanderberkhout commented Dec 23, 2021

syoon2 commented Aug 4, 2023 •

edited

Loading

DevCharly commented Aug 4, 2023

syoon2 commented Aug 5, 2023

DevCharly commented Aug 5, 2023

syoon2 commented Aug 5, 2023 •

edited

Loading

Support for Windows on ARM 64-bit #443

Support for Windows on ARM 64-bit #443

Comments

xanderberkhout commented Dec 14, 2021

DevCharly commented Dec 14, 2021

xanderberkhout commented Dec 14, 2021 • edited Loading

xanderberkhout commented Dec 14, 2021 • edited Loading

DevCharly commented Dec 15, 2021

xberkhout commented Dec 15, 2021 • edited Loading

xanderberkhout commented Dec 22, 2021

DevCharly commented Dec 23, 2021

xanderberkhout commented Dec 23, 2021

DevCharly commented Dec 23, 2021

xanderberkhout commented Dec 23, 2021 • edited Loading

xanderberkhout commented Dec 23, 2021

syoon2 commented Aug 4, 2023 • edited Loading

DevCharly commented Aug 4, 2023

syoon2 commented Aug 5, 2023

DevCharly commented Aug 5, 2023

syoon2 commented Aug 5, 2023 • edited Loading

xanderberkhout commented Dec 14, 2021 •

edited

Loading

xanderberkhout commented Dec 14, 2021 •

edited

Loading

xberkhout commented Dec 15, 2021 •

edited

Loading

xanderberkhout commented Dec 23, 2021 •

edited

Loading

syoon2 commented Aug 4, 2023 •

edited

Loading

syoon2 commented Aug 5, 2023 •

edited

Loading