macOS: native rounded borders for popups #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've tested this only on macOS 10.14 (Intel) and on 13.3 (M1). Would be great to get some feedback whether this works without problems on other macOS versions. Prebuilt binaries are available here (requires GitHub login): |
- removed `FlatNativeMacLibrary.getWindowPtr()` because it is too dangerous to use `windowPtr` (which is `NSWindow*`) in Java (using invalid window pointer would crash app) - made `getNSWindow()` 20x faster - catch exceptions in `getNSWindow()` - digitally signed dylibs
DevCharly
added a commit
that referenced
this pull request
Jul 15, 2024
…OS 14.4+ because it may freeze the application and crash the macOS WindowServer process
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables native macOS rounded borders (including drop shadow) for popups. (issue #715)
PopupMenu:
ComboBox (macOS theme):
ToolTip:
The rounded popup borders are enabled by default for all themes and
use the same UI properties and client property as in PR #643.
Additionally there are 4 new UI properties:
The first three are used for
JPopupMenu,JComboBoxandJToolTip.The last one is used for other components shown as popup via
PopupFactory.getPopup().There is also a client property
Popup.roundedBorderWidththat allows changing rounded border width for specific popups.roundedBorderWidthis used only on macOS.The default value is
0for light themes (because macOS always adds a thin dark border),and
1for dark themes (to add a lighter border to the popup, otherwise it is difficult to distinguish the popup from the background).