Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table: rounded selection #856

Merged
merged 3 commits into from
Jul 15, 2024
Merged

Table: rounded selection #856

merged 3 commits into from
Jul 15, 2024

Conversation

DevCharly
Copy link
Collaborator

This PR enables using "rounded" selection for table selection.

This is not yet used in any theme, but intended to be used in the future.

Examples

Row selection

grafik

UI properties for above screenshot (see Application properties files):

Table.selectionArc = 6
Table.selectionInsets = 0,1,0,1

Column selection

grafik

UI properties for above screenshot:

Table.selectionArc = 6

Cell selection

grafik

UI properties for above screenshot:

Table.selectionArc = 6
Table.selectionInsets = 0,1,0,1

@DevCharly DevCharly added this to the 3.5 milestone Jun 24, 2024
@DevCharly
Copy link
Collaborator Author

A snapshot for this PR is now available.
Use PR-856-SNAPSHOT as version.
https://github.com/JFormDesigner/FlatLaf#snapshots

@DJ-Raven
Copy link
Contributor

I see this Issues when selected row then unselected some row

2024-06-26_230337

@stefanoschalkidis
Copy link

I can confirm the issue for MULTIPLE_INTERVAL_SELECTION. Also, if one selects a few lines, leaves out a line, selects a line, and then selects the left out line there will be a dent at the edge of the selection. SINGLE_SELECTION works fine.

flatlaf_rounded_table_selection

@DevCharly
Copy link
Collaborator Author

@DJ-Raven and @stefanoschalkidis many thanks for reporting.
Should be fixed now 😉

@DevCharly DevCharly merged commit cba203b into main Jul 15, 2024
8 checks passed
@DevCharly DevCharly deleted the table-rounded-selection branch July 15, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants