You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The remaining test failures are having to do with tidyverse/readr#963. We could either: Ignore the failures for now and see if the fix gets merged. Or since readr now:
We now write the connection to a temporary file (in the R temporary directory), than parse that temporary file.
We probably no longer see the performance benefit from using pipe instead of system2. We could just manage writing to the temporary file ourselves and we could sidestep the readr bug. We could then also get better error messages as well. Although this really applies to local DB connections and remote DB connections may still suffer from the bug (I'm not sure since it calls readr indirectly via httr package).
Is this bug causing people problems right now? If not, then we can probably wait to see if they merge a fix. If it is, or if the fix takes too long, then we should probably devise our own workaround.
No, I don't think this bug is going to really cause any rgcam users any real trouble. It is really only about graceful error messages so the worst that can happen is we get a question about what does "Cannot read file" error mean?.
And I don't really have to time to deal with it so I am just going to punt for now.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update comparison data and fix test for the new version of readr's column type behavior.