Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for python 3.12 #310

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Update for python 3.12 #310

wants to merge 2 commits into from

Conversation

EliusSolis
Copy link

Fixes to reflect changes in cython 3.11 and 3.12, mainly PEP 674 and python/cpython#101292

@Herbrant
Copy link

Hi! I tested your PR. I think you also need to replace the PyDict_GET_SIZE calls with PyUnicode_GET_LENGTH, then it works fine.
Thank you for your help.

Copy link

@BatchClayderman BatchClayderman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the nice update. I used this version to build the Python charm for Python 3.12 and it worked fine. I have been using this version with Python 3.12 under the Ubuntu (24.04.1 LTS) operating system (WSL) for over a month. Everything seems pretty. Testing schemes work correctly. It is my sincere hope that this branch can be merged. Merry Christmas and Happy New Year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants