Fix Issue #313 and optimize based on Issue #312 #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue JHUISI#313 - Fix the multiple GT element generation issue. - Modify the original recursive logic to a simpler ``if-else`` logic. - Pre-generate the ``__gt`` when the object is instantiated, without having to check whether ``__gt`` has been generated every time a random GT element is required to be generated. - No seeds will be passed to the imported ``random`` function to generate different random elements when multiple elements are required to be generated even though a seed is specified to call the ``random`` method of the ``PairingGroup`` class. Issue JHUISI#312 - Optimize the ``/ 8`` to ``>> 3``.
Issue JHUISI#313 - Fix the multiple GT element generation issue. - Modify the original recursive logic to a simpler ``if-else`` logic. - Pre-generate the ``__gt`` when the object is instantiated, without having to check whether ``__gt`` has been generated every time a random GT element is required to be generated. - No seeds will be passed to the imported ``random`` function to generate different random elements when multiple elements are required to be generated even though a seed is specified to call the ``random`` method of the ``PairingGroup`` class. Issue JHUISI#312 - Optimize the ``/ 8`` to ``>> 3``.
jakinyele
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
Looks good. Thank you for your contribution @BatchClayderman!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #313
if-elselogic.__gtwhen the object is instantiated, without having to check whether__gthas been generated every time a random GT element is required to be generated.randomfunction to generate different random elements when multiple elements are required to be generated even though a seed is specified to call therandommethod of thePairingGroupclass.Issue #312
/ 8to>> 3.There should be two commits in this pull request. If the official thinks adding
seed1andseed2in the construction function of thePairingGroupclass can destroy the consistency with constructors of other classes, please kindly refer to the first commit, or remove the two parameters in the construction function directly.Tested on Ubuntu 24.04.1 LTS:
Thank you so much for offering this opportunity.